chore: remove pre-commit hook #368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So far, a pre-commit hook was triggered by default that ran
npm testwhenever you committed. I personally found this a bit annoying and always removed the hooks manually, but due to the configuration inpackage.json, they are always reinstalled whenever you invokenpm install.This PR gets rid of the hooks by removing the
pre-commitdependency and thepre-commitfield inpackage.json. This gives us developers a bit more control without sacrificing code quality here on GitHub since the CI action is running anyway, ensuring that the code base passes all tests.This is just a personal preference, though, if you would like to keep the hook, we could also leave it as is and close this PR :)