Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update dependencies #356

Merged
merged 3 commits into from
Jan 2, 2023
Merged

Update dependencies #356

merged 3 commits into from
Jan 2, 2023

Conversation

JKRhb
Copy link
Member

@JKRhb JKRhb commented Nov 23, 2022 •
edited
Loading

This PR reactivates all tests (all except one have mistakenly been disabled), updates all dependencies, and cleans up/updates some code that used deprecated definitions.

@JKRhb JKRhb force-pushed the dependencies branch 3 times, most recently from ee861a3 to 29aa2cf Compare November 23, 2022 18:21
@coveralls
Copy link

coveralls commented Nov 23, 2022 •
edited
Loading

Pull Request Test Coverage Report for Build 3820689246

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.2%) to 91.61%
Totals Coverage Status
Change from base Build 3820665973: -0.2%
Covered Lines: 2842
Relevant Lines: 3059
💛 - Coveralls

@JKRhb JKRhb force-pushed the dependencies branch 2 times, most recently from e99ae8e to e0aab36 Compare November 23, 2022 18:53
@JKRhb JKRhb marked this pull request as ready for review November 23, 2022 18:57
@JKRhb JKRhb requested a review from Apollon77 November 23, 2022 18:58
@JKRhb
Copy link
Member Author

JKRhb commented Nov 23, 2022

Hmm. Very weird, a couple of jobs are failing for some reason :/

@JKRhb JKRhb force-pushed the dependencies branch 2 times, most recently from 089a8a3 to 700a484 Compare November 23, 2022 21:25
@JKRhb JKRhb mentioned this pull request Nov 23, 2022
Merged
@JKRhb JKRhb marked this pull request as draft November 23, 2022 21:48
@JKRhb JKRhb force-pushed the dependencies branch 6 times, most recently from d2a4952 to e14fa26 Compare January 2, 2023 05:39
@JKRhb JKRhb force-pushed the dependencies branch 2 times, most recently from 68ced00 to d475623 Compare January 2, 2023 06:14
@JKRhb JKRhb changed the title Update dependencies, reactivate tests Update dependencies Jan 2, 2023
@JKRhb JKRhb marked this pull request as ready for review January 2, 2023 06:20
@JKRhb
Copy link
Member Author

JKRhb commented Jan 2, 2023

Factored out the problematic cases into #360 and #361, so this one could also be merged now :)

@JKRhb JKRhb merged commit 784ab9a into coapjs:master Jan 2, 2023
@JKRhb JKRhb deleted the dependencies branch January 2, 2023 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Apollon77 Apollon77 Awaiting requested review from Apollon77

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JKRhb @coveralls