Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated K8s version #384

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

AryanSharma9917
Copy link
Contributor

PR Title:

Update Kubernetes dependencies to v0.30.0

Description:

This PR updates the following Kubernetes dependencies to v0.30.0 to align with the latest K8s v1.30 release:

  • k8s.io/api from v0.29.1 to v0.30.0
  • k8s.io/apiextensions-apiserver from v0.29.1 to v0.30.0
  • k8s.io/apimachinery from v0.29.1 to v0.30.0
  • k8s.io/client-go from v0.29.1 to v0.30.0

These updates are necessary to leverage the latest Kubernetes features and improvements, ensure compatibility with the Kubernetes v1.30 cluster, and maintain stability and security in our project.

Related Issue:

Resolves #260

Checklist:

  • Updated go.mod and go.sum files.
  • Verified the project builds correctly with the updated dependencies.
  • Tested the changes in a development environment to ensure compatibility.

@AryanSharma9917 AryanSharma9917 requested a review from a team as a code owner September 9, 2024 15:49
@AryanSharma9917
Copy link
Contributor Author

@nabuskey could you please review this PR!

@nabuskey
Copy link
Contributor

@AryanSharma9917 Looks like it's not building correctly. Would you please take a look? https://github.com/cnoe-io/idpbuilder/actions/runs/10776701846/job/29884087640?pr=384

@nabuskey
Copy link
Contributor

@AryanSharma9917 Any progress on this? I'd like to do this before cutting the next release.

Signed-off-by: AryanSharma9917 <sharmaaryan9837@gmail.com>
Signed-off-by: Aryan Sharma <sharmaaryan9837@gmail.com>
Signed-off-by: Aryan Sharma <sharmaaryan9837@gmail.com>
Signed-off-by: Aryan Sharma <sharmaaryan9837@gmail.com>
Signed-off-by: Aryan Sharma <sharmaaryan9837@gmail.com>
Signed-off-by: Aryan Sharma <sharmaaryan9837@gmail.com>
Signed-off-by: Aryan Sharma <sharmaaryan9837@gmail.com>
@AryanSharma9917
Copy link
Contributor Author

@nabuskey could you please look into it?

go.mod Outdated
Comment on lines 16 to 21
k8s.io/api v0.31.0
k8s.io/apiextensions-apiserver v0.31.0
k8s.io/apimachinery v0.31.0
k8s.io/client-go v0.31.0
k8s.io/klog/v2 v2.130.1
sigs.k8s.io/controller-runtime v0.19.0
Copy link
Contributor

@nabuskey nabuskey Oct 1, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we want v0.30, not v0.31. Controller-runtime should be 18.5. It's likely fine to have different versions but I'd like to keep the ArgoCD api and this repository in sync.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AryanSharma9917 Any update on this? It's been a while since we released idpbuilder version and we implemented some QOL changes so I'd like to release one soon. Let me know if you have any questions.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done..!

Signed-off-by: Aryan Sharma <sharmaaryan9837@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update k8s to 1.30
2 participants