Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove examples directory #280

Merged
merged 1 commit into from
Jun 17, 2024
Merged

remove examples directory #280

merged 1 commit into from
Jun 17, 2024

Conversation

nabuskey
Copy link
Contributor

@nabuskey nabuskey commented Jun 4, 2024

This PR removes the examples directory and references the stacks repository instead.

Need:

closes: #279

@nimakaviani
Copy link
Contributor

I love PRs like this. will need to take some time to read the README and also update the CNOE website accordingly before merging this in. but hopefully before the end of the week.

@nabuskey
Copy link
Contributor Author

nabuskey commented Jun 5, 2024

Yeah thinking about it, we need to update the stacks readme too. Let's wait a bit.

Signed-off-by: Manabu McCloskey <manabu.mccloskey@gmail.com>
Copy link
Contributor

@nimakaviani nimakaviani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nimakaviani nimakaviani merged commit e8e2319 into cnoe-io:main Jun 17, 2024
3 checks passed
@nabuskey nabuskey deleted the rm-examples branch June 17, 2024 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cleanup - remove the examples directory and fix docs
2 participants