This repository has been archived by the owner on Jun 14, 2024. It is now read-only.
Do not merge: Add versioning #108
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kapunahelewong
force-pushed
the
versioning
branch
2 times, most recently
from
fafb005
to
95e424b
Compare
Signed-off-by: Kapunahele Wong <kapunahelewong@gmail.com>
kapunahelewong
force-pushed
the
versioning
branch
from
95e424b
to
2b593ab
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a work in progress for adding versioning to the starter, but I'm stuck. I have borrowed
version-banner.htmlandnavbar-version-selector.htmlfrom etcd.io. However, I'm unsure how to truly tie the pieces together (and so have left the files and snippets unedited).The preview won't show anything other than "Versions" in the navbar (which has no functionality), as I need clarification on what other pieces are needed to make this work.
I'd appreciate any pointers! Thank you!