-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some more python 2to3 fixes for HLT #34583
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34583/24134
|
A new Pull Request was created by @Martin-Grunewald (Martin Grunewald) for master. It involves the following packages:
@Martin-Grunewald, @cmsbuild can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
urgent |
type bug-fix |
-1 Failed Tests: RelVals RelVals
|
Failure unrelated to this PR, also in baseline IB CMSSW_12_0_X_2021-07-21-2300. |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (but tests are reportedly failing). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy, @perrotta (and backports should be raised in the release meeting by the corresponding L2) |
please test with PR #34534 |
please test with #34534 |
-1 Failed Tests: UnitTests RelVals Unit TestsI found errors in the following unit tests: ---> test test_MuonGeometryDBConverter had ERRORS ---> test testDD4hepCompactView had ERRORS ---> test DetectorDescriptionDDCMSTestDriver had ERRORS ---> test testDD4hepFilteredView had ERRORS and more ... RelVals
|
please test |
-1 Failed Tests: RelVals RelVals
|
please test |
-1 Failed Tests: RelVals-INPUT RelVals-INPUT
Expand to see more relval errors ...
Comparison SummarySummary:
|
There must be a problem with the PR test infrastructure - this PR could not possibly create such errors in the PR tests... |
also appeared in the IB: CMSSW_12_0_X_2021-07-22-1700 Let's re-trigger the test with new IB |
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3026dc/17140/summary.html Comparison SummarySummary:
|
+1 |
PR description:
Some more python 2to3 fixes for HLT
PR validation:
TSG tests
if this PR is a backport please specify the original PR and why you need to backport that PR:
N/A