python2 cleanup: Validation packages

[jfernan2]

PR description:

Mostly private scripts.

[jfernan2]

please test

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34427/23836

• This PR adds an extra 472KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34427/23836/code-format.patch
  e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34427/23836/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[jfernan2]

please test

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34427/23837

• This PR adds an extra 472KB to repository

[cmsbuild]

A new Pull Request was created by @jfernan2 for master.

It involves the following packages:

• Validation/CaloTowers (dqm)
• Validation/EcalClusters (dqm)
• Validation/Geometry (geometry, dqm)
• Validation/HGCalValidation (dqm)
• Validation/MuonGEMHits (dqm)
• Validation/Performance (core)
• Validation/RecoB (dqm)
• Validation/RecoEgamma (dqm)
• Validation/RecoMuon (dqm)
• Validation/RecoParticleFlow (dqm)
• Validation/RecoTau (dqm)
• Validation/RecoTrack (dqm)
• Validation/RecoVertex (dqm)
• Validation/Tools (core)

@smuzaffar, @civanch, @Dr15Jones, @kmaeshima, @cvuosalo, @andrius-k, @mdhildreth, @ianna, @makortel, @jfernan2, @ahmad3213, @ErnestaP, @rvenditti can you please review it and eventually sign? Thanks.
@emilbols, @felicepantaleo, @abbiendi, @argiro, @jshlee, @bsunanda, @pfs, @thomreis, @rishabhCMS, @mmusich, @cericeci, @venturia, @sethzenz, @JyothsnaKomaragiri, @makortel, @abdoulline, @JanFSchulte, @watson-ij, @dgulhan, @apsallid, @sscruz, @simonepigazzini, @trocino, @lgray, @rociovilar, @vandreev11, @GiacomoSguazzoni, @rovere, @VinInn, @cseez, @wmtford, @ebrondol, @mtosi, @fabiocos, @rbartek, @HuguesBrun, @rchatter, @vargasa, @Fedespring, @calderona, @hatakeyamak, @jhgoh, @lecriste, @andrzejnovak this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy, @perrotta you are the release manager for this.

cms-bot commands are listed here

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0b9cec/16649/summary.html
COMMIT: eb77924
CMSSW: CMSSW_12_0_X_2021-07-09-0800/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/34427/16649/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 38
• DQMHistoTests: Total histograms compared: 2786260
• DQMHistoTests: Total failures: 7
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2786231
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 37 files compared)
• Checked 160 log files, 37 edm output root files, 38 DQM output files
• TriggerResults: no differences found

[smuzaffar]

+core
for Validation/Performance and Validation/Tools

[cvuosalo]

@jfernan2 How did you validate these changes? Did you run every affected script?

[jfernan2]

Hi @cvuosalo
I only checked python3 intepreter did not complain since most of them are private scripts no affecting Production

[jfernan2]

+1

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34427/24410

• This PR adds an extra 356KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File Validation/RecoParticleFlow/test/compare.py modified in PR(s): Adding jet efficiency and purity plots #34580

[cmsbuild]

Pull request #34427 was updated. @smuzaffar, @civanch, @Dr15Jones, @kmaeshima, @cvuosalo, @andrius-k, @mdhildreth, @ianna, @cmsbuild, @makortel, @jfernan2, @ahmad3213, @ErnestaP, @rvenditti can you please check and sign again.

[jfernan2]

+1

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0b9cec/17560/summary.html
COMMIT: 2adc2cd
CMSSW: CMSSW_12_1_X_2021-08-04-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/34427/17560/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 39
• DQMHistoTests: Total histograms compared: 2999410
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2999387
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 38 files compared)
• Checked 165 log files, 37 edm output root files, 39 DQM output files
• TriggerResults: no differences found

[perrotta]

@cms-sw/geometry-l2 @cms-sw/core-l2 you already signed this PR before the last rebase.
If you don't have any other issues now, could you please sign it again, so that it can be merged (thus avoiding a possible further rebase)?

[Dr15Jones]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1