Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix a few small bugs #20

Merged
merged 4 commits into from
Feb 8, 2022
Merged

fix a few small bugs #20

merged 4 commits into from
Feb 8, 2022

Conversation

mcalhoun
Copy link
Member

@mcalhoun mcalhoun commented Feb 8, 2022

what

  • Update incorrect provider config
  • Remove unused variable
  • Add .terraform.lock.hcl to the .gitignore

why

  • The main driver for this PR was that we previously had:
required_providers {
    local = {
      source  = "hashicorp/aws"
      version = ">= 3.0"
    }
  }
}

This lead to a misconfiguration which caused the AWS provider not to function properly and lead to several hours of debugging.

@mcalhoun mcalhoun requested review from a team as code owners February 8, 2022 19:41
@nitrocode nitrocode added the patch A minor, backward compatible change label Feb 8, 2022
@mcalhoun
Copy link
Member Author

mcalhoun commented Feb 8, 2022

/test all

@mcalhoun mcalhoun merged commit 7f791c0 into main Feb 8, 2022
@mcalhoun mcalhoun deleted the chore/fix-bug-in-template branch February 8, 2022 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch A minor, backward compatible change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants