feat: manage master credentials in secrets manager #218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamengual
approved these changes
Jun 18, 2024
|
/terratest |
jamengual
reviewed
Jun 18, 2024
| @@ -60,6 +60,18 @@ variable "db_port" { | |||
| description = "Database port" | |||
| } | |||
|
|
|||
| variable "manage_admin_user_password" { | |||
| type = string | |||
| default = false | |||
There was a problem hiding this comment.
This is not correct, this should be null
There was a problem hiding this comment.
The type should be boolean, instead of string
pazaan
pushed a commit
to pazaan/terraform-aws-rds-cluster
that referenced
this pull request
Jul 10, 2024
This was referenced Jul 10, 2024
gberenice
pushed a commit
that referenced
this pull request
Jul 24, 2024
* feat: manage master credentials in secrets manager * fix: address PR comments See #218 * generate README * fix: address PR comments * chore: update README * fix: manage_master_user_password must be `null` or `true` * fix: make `manage_master_user_password` logic more readable per PR request --------- Co-authored-by: Marat Salimzianov <salemgolemugoo@users.noreply.github.com> Co-authored-by: Lennart Goedhart <lgoedhart-ic@akiliinteractive.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
Allow to manage master credentials in Secrets Manager
why
Managed secrets are more secure and easy to use.
references
(closes #166)