Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bumping AWS provider version to ~> 3.0.0 #25

Closed
wants to merge 2 commits into from
Closed

Bumping AWS provider version to ~> 3.0.0 #25

wants to merge 2 commits into from

Conversation

danjbh
Copy link
Contributor

@danjbh danjbh commented Aug 27, 2020 •
edited
Loading

what

  • Bumping our AWS provider to version 3

why

  • Allows us to take advantage of some newer Terraform features when deploying EKS
  • For example, this will provide us with the ability to specify custom launch templates in aws_eks_node_group

references

aws/containers-roadmap#585

@danjbh danjbh requested a review from a team as a code owner August 27, 2020 00:28
@danjbh danjbh requested review from adamcrews and SweetOps and removed request for a team August 27, 2020 00:28
@danjbh
Copy link
Contributor Author

danjbh commented Aug 27, 2020

/test all

@danjbh danjbh marked this pull request as draft August 27, 2020 00:34
@danjbh
Copy link
Contributor Author

danjbh commented Aug 27, 2020

I've got some more work to do on this one -- stay tuned!

@dotCipher dotCipher mentioned this pull request Aug 27, 2020
Closed
@dotCipher
Copy link
Contributor

Excited to have seen this was already being worked on! I actually just got a use-case for using launch templates and submitted the issue: #24

@danjbh
Copy link
Contributor Author

danjbh commented Aug 27, 2020

I was originally thinking that we could start by bumping the AWS versions for any modules commonly used in this pattern (e.g. terraform-aws-eks-cluster), but instead I'm going to create a new branch and start working on the launch template functionality today. I'll update #24 with the new PR when it's ready (hopefully later today) 👍

@danjbh danjbh closed this Aug 27, 2020
@danjbh danjbh deleted the update-aws-provider-version branch August 27, 2020 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamcrews adamcrews Awaiting requested review from adamcrews

@SweetOps SweetOps Awaiting requested review from SweetOps

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danjbh @dotCipher