Better block device support #150

Nuru · 2023-08-03T12:16:17Z

Notable Changes

With this PR/release, the default type of block device changes from gp2 to gp3. If you were relying on the default, this will cause your node group to change, but it should be without interruption.
We no longer automatically apply a custom taint to Window nodes. Pods should select (or not) Windows nodes via the kubernetes.io/os tag. If that is not sufficient, you are free to add your own "NO_EXECUTE" taint via kubernetes_taints

Take advantage of optional() to allow the block device mapping input to be fully specified, with defaults, rather than the previous list(any), which had no type checking and did not advertise which features were or were not supported
Closes chore(deps): update terraform cloudposse/security-group/aws to v2 - abandoned #134
Bad practices that were not caught in time

Nuru · 2023-08-03T12:17:56Z

/terratest

max-lobur · 2023-08-03T13:47:50Z

variables.tf

-    encrypted             = true
-    delete_on_termination = true
-  }]
+  default = { "/dev/xvda" = { ebs = {} } }


Suggestion: Add known operating systems and their default storage in description notes

Nuru added 3 commits August 2, 2023 20:12

Late reviewer feedback for PR #139

c19978e

Update security group to v2

2b8211e

Replace block_device_mappings with block_device_map

9fccc7d

Nuru requested review from a team as code owners August 3, 2023 12:16

Nuru requested review from dotCipher, woz5999, dudymas, aknysh, milldr and Benbentwo August 3, 2023 12:16

Nuru added the minor New features that do not break anything label Aug 3, 2023

max-lobur approved these changes Aug 3, 2023

View reviewed changes

max-lobur reviewed Aug 3, 2023

View reviewed changes

Nuru merged commit 80e8786 into main Aug 3, 2023
16 checks passed

Nuru deleted the block-devices branch August 3, 2023 19:28