Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support AWS Provider V5 #147

Merged
merged 1 commit into from
Aug 3, 2023
Merged

Support AWS Provider V5 #147

merged 1 commit into from
Aug 3, 2023

Conversation

max-lobur
Copy link
Contributor

what

Support AWS Provider V5
Linter fixes

why

Maintenance

references

https://github.com/hashicorp/terraform-provider-aws/releases/tag/v5.0.0

@max-lobur max-lobur added the no-release Do not create a new release (wait for additional code changes) label Jun 7, 2023
@max-lobur max-lobur requested review from a team as code owners June 7, 2023 16:42
@max-lobur
Copy link
Contributor Author

/terratest

@@ -22,7 +22,7 @@ locals {
# e.g. amazon-eks-arm64-node-1.21-v20211013
AL2 = "amazon-eks%s-node-%s"
# bottlerocket-aws-k8s-{ami_kubernetes_version}-{arch_label}-v{ami_version}
# e.g. bottlerocket-aws-k8s-1.21-x86_64-v1.2.0-ccf1b754
# e.g. bottlerocket-aws-k8s-1.21-x86_64-v1[2].0-ccf1b754
Copy link
Sponsor Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revert grep error

Suggested change
# e.g. bottlerocket-aws-k8s-1.21-x86_64-v1[2].0-ccf1b754
# e.g. bottlerocket-aws-k8s-1.21-x86_64-v1.2.0-ccf1b754

@Nuru Nuru merged commit 2b1f129 into main Aug 3, 2023
@Nuru Nuru deleted the aws_v5 branch August 3, 2023 02:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-release Do not create a new release (wait for additional code changes)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants