Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add tags_all to the output #112

Closed
wants to merge 6 commits into from
Closed

feat: add tags_all to the output #112

wants to merge 6 commits into from

Conversation

ib-ak
Copy link

@ib-ak ib-ak commented Mar 2, 2022

what

adds tags_all to the output

why

  • missing output from the module
  • tags_all can be used as input to tag ASG

references

@ib-ak ib-ak requested review from a team as code owners March 2, 2022 13:08
@ib-ak ib-ak requested review from Gowiem and dotCipher March 2, 2022 13:08
@mergify
Copy link

mergify bot commented Mar 2, 2022

This pull request is now in conflict. Could you fix it @abhinavkhanna-sf? 🙏

@Gowiem
Copy link
Member

Gowiem commented May 16, 2022

/test all

Gowiem
Gowiem approved these changes May 16, 2022
View reviewed changes
Copy link
Member

@Gowiem Gowiem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@Nuru Nuru mentioned this pull request May 21, 2022
Merged
@Nuru Nuru closed this in #118 May 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gowiem Gowiem Gowiem approved these changes

@dotCipher dotCipher Awaiting requested review from dotCipher dotCipher was automatically assigned from cloudposse/contributors

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Expose tags_all output
3 participants
@ib-ak @Gowiem @cloudpossebot