Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update pet name when changing launch template id #106

Closed
wants to merge 2 commits into from
Closed

Update pet name when changing launch template id #106

wants to merge 2 commits into from

Conversation

woz5999
Copy link
Contributor

@woz5999 woz5999 commented Jan 19, 2022

what

  • Update pet name when changing launch template id

why

  • If you change the template id, tf/aws will try to create a new node group; however, because we're using create before destroy, it errors out due to "NodeGroup already exists with name food and cluster name bar"
  • generating a new pet name will restore the correct behavior
  • note that this was the behavior prior to Overhaul Overhaul #84

@woz5999 woz5999 requested review from a team as code owners January 19, 2022 23:35
@woz5999 woz5999 requested review from Gowiem and milldr January 19, 2022 23:35
@woz5999
Copy link
Contributor Author

woz5999 commented Jan 19, 2022

/test all

@woz5999
Copy link
Contributor Author

woz5999 commented Jan 19, 2022 •
edited
Loading

@aknysh i ended up just creating a new fork since mine was so old. here's the fixed version of !105

@woz5999 woz5999 requested a review from aknysh January 26, 2022 17:11
@woz5999
Copy link
Contributor Author

woz5999 commented Jan 31, 2022

anyone available to review this?

@woz5999
Copy link
Contributor Author

woz5999 commented Feb 1, 2022

/test all

@woz5999
Copy link
Contributor Author

woz5999 commented Feb 9, 2022

@aknysh @Nuru @Gowiem is anyone able to review this?

@Gowiem
Copy link
Member

Gowiem commented Feb 9, 2022

Since @Nuru did #84, I'll leave it to him.

@nitrocode nitrocode requested a review from Nuru February 24, 2022 01:36
@nitrocode nitrocode added the patch A minor, backward compatible change label Feb 28, 2022
@Nuru Nuru mentioned this pull request Mar 2, 2022
Merged
@Nuru Nuru closed this in #110 Mar 2, 2022
@bwmetcalf bwmetcalf mentioned this pull request May 26, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gowiem Gowiem Awaiting requested review from Gowiem Gowiem was automatically assigned from cloudposse/contributors

@milldr milldr Awaiting requested review from milldr milldr was automatically assigned from cloudposse/contributors

@aknysh aknysh Awaiting requested review from aknysh

@Nuru Nuru Awaiting requested review from Nuru

Assignees
No one assigned
Labels
patch A minor, backward compatible change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@woz5999 @Gowiem @nitrocode