Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Output launch template name #103

Closed
wants to merge 6 commits into from
Closed

Output launch template name #103

wants to merge 6 commits into from

Conversation

bwmetcalf
Copy link

@bwmetcalf bwmetcalf commented Jan 12, 2022 •
edited by nitrocode
Loading

what

Adds launch template name to outputs

why

  • This is useful for cases where a tool like karpenter is used to scale nodes and the same launch template should be used.

references

aknysh
aknysh reviewed Jan 12, 2022
View reviewed changes
outputs.tf Outdated Show resolved Hide resolved
aknysh
aknysh previously requested changes Jan 12, 2022
View reviewed changes
Copy link
Member

@aknysh aknysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @bwmetcalf please see comments

@bwmetcalf @aknysh
Update outputs.tf
d33e3d9 
Co-authored-by: Andriy Knysh <aknysh@users.noreply.github.com>
@mergify mergify bot dismissed aknysh’s stale review January 12, 2022 19:04

This Pull Request has been updated, so we're dismissing all reviews.

@bwmetcalf
Copy link
Author

thanks @bwmetcalf please see comments

Thanks @aknysh. I was about to start testing, but wanted to get draft MR out there. Suggestion committed.

@bwmetcalf bwmetcalf marked this pull request as ready for review January 12, 2022 19:06
@bwmetcalf bwmetcalf requested review from a team as code owners January 12, 2022 19:06
@leb4r
Copy link

leb4r commented Jan 14, 2022

/test all

nitrocode
nitrocode reviewed Feb 24, 2022
View reviewed changes
outputs.tf Outdated Show resolved Hide resolved
@bwmetcalf @nitrocode
Update outputs.tf
f285ceb 
Co-authored-by: nitrocode <nitrocode@users.noreply.github.com>
@Nuru Nuru mentioned this pull request Mar 2, 2022
Merged
@Nuru Nuru closed this in #110 Mar 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nitrocode nitrocode nitrocode left review comments

@aknysh aknysh aknysh left review comments

@florian0410 florian0410 Awaiting requested review from florian0410 florian0410 was automatically assigned from cloudposse/contributors

@leb4r leb4r Awaiting requested review from leb4r leb4r was automatically assigned from cloudposse/contributors

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Output aws_launch_template.default.name
5 participants
@bwmetcalf @leb4r @aknysh @nitrocode @cloudpossebot