Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support for ebs optimization in launch templates #101

Merged
merged 6 commits into from
Jan 12, 2022
Merged

support for ebs optimization in launch templates #101

merged 6 commits into from
Jan 12, 2022

Conversation

jrowinski3d
Copy link
Contributor

what

  • Enabled EBS Optimization in the launch template.

why

  • Give the user ability to enable ebs optimization, default will be false. Of course the instance_type will need to be capable of doing so.

references

@jrowinski3d jrowinski3d requested review from a team as code owners January 11, 2022 23:14
aknysh
aknysh reviewed Jan 11, 2022
View reviewed changes
launch-template.tf Outdated Show resolved Hide resolved
aknysh
aknysh reviewed Jan 11, 2022
View reviewed changes
launch-template.tf Outdated Show resolved Hide resolved
aknysh
aknysh reviewed Jan 11, 2022
View reviewed changes
variables.tf Outdated Show resolved Hide resolved
aknysh
aknysh reviewed Jan 11, 2022
View reviewed changes
Copy link
Member

@aknysh aknysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jrowinski3d thank you
please see comments

@jrowinski3d
Copy link
Contributor Author

@jrowinski3d thank you please see comments

Thank you, sorry missed those. I updated to your recommendations.

@aknysh
Copy link
Member

aknysh commented Jan 12, 2022

/test all

@aknysh aknysh added the patch A minor, backward compatible change label Jan 12, 2022
@aknysh aknysh merged commit c971393 into cloudposse:master Jan 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aknysh aknysh aknysh approved these changes

@Makeshift Makeshift Awaiting requested review from Makeshift Makeshift was automatically assigned from cloudposse/contributors

@SweetOps SweetOps Awaiting requested review from SweetOps SweetOps was automatically assigned from cloudposse/contributors

Assignees
No one assigned
Labels
patch A minor, backward compatible change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

EBS Optimization
3 participants
@jrowinski3d @aknysh @cloudpossebot