Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update module versions, README, LICENSE, Go version. Pin the kubernetes provider #201

Closed
wants to merge 2 commits into from

Conversation

aknysh
Copy link
Member

@aknysh aknysh commented Jan 5, 2024

what

  • Update module versions, README, LICENSE, Go version for tests
  • Pin the kubernetes provider

why

  • Keep up to date

  • Limited the kubernetes provider to versions less than 2.25.0 since major changes were introduced in 2.25.0 that broke the terraform-aws-eks-cluster module. The kubernetes provider was updated to use the terraform-plugin-framework, which does not support computed lists in the exec block:

dynamic "exec" {
  content {
   args = concat(local.exec_profile, ["eks", "get-token", "--cluster-name", try(aws_eks_cluster.default[0].id, "deleted")], local.exec_role)
  }
}

Processing the computed args list throws the error:

Target Type: []struct { Args []basetypes.StringValue "tfsdk:\"args\"" }
Suggested Type: basetypes.ListValue

references

@aknysh aknysh self-assigned this Jan 5, 2024
@aknysh aknysh requested review from a team as code owners January 5, 2024 20:32
Copy link

@bridgecrew bridgecrew bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bridgecrew has found errors in this PR ⬇️

test/src/go.mod Show resolved Hide resolved
test/src/go.mod Show resolved Hide resolved
@aknysh
Copy link
Member Author

aknysh commented Jan 5, 2024

/terratest

@aknysh
Copy link
Member Author

aknysh commented Jan 5, 2024

/terratest

@aknysh aknysh marked this pull request as draft January 5, 2024 22:17
@hans-d hans-d added the stale This PR has gone stale label Mar 5, 2024
@Nuru Nuru closed this in #206 Mar 11, 2024
@mergify mergify bot removed the stale This PR has gone stale label Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants