Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add windows support #175

Closed
wants to merge 3 commits into from
Closed

add windows support #175

wants to merge 3 commits into from

Conversation

ChrisMcKee
Copy link

what

  • Adds windows support flag which adds the extra required policy and the config map for amazon-vpc-cni
  • Sets default version to 1.24 (current latest)

why

  • Setting up windows requires extra steps; the basics are easy to bake in

references

@ChrisMcKee ChrisMcKee requested review from a team as code owners January 3, 2023 18:12
@ChrisMcKee ChrisMcKee mentioned this pull request Feb 24, 2023
Merged
@hans-d hans-d added stale This PR has gone stale wip Work in Progress: Not ready for final review or merge and removed wip Work in Progress: Not ready for final review or merge labels Mar 8, 2024
@mergify Mergify
Copy link

mergify bot commented Mar 8, 2024

This pull request is now in conflict. Could you fix it @ChrisMcKee? 🙏

@mergify mergify bot added the conflict This PR has conflicts label Mar 11, 2024
@mergify mergify bot closed this Mar 11, 2024
@mergify Mergify
Copy link

mergify bot commented Mar 11, 2024

This PR has been closed due to inactivity and merge conflicts.
Please resolve the conflicts and reopen if necessary.

@mergify Mergify
Copy link

mergify bot commented Mar 11, 2024

Thanks @ChrisMcKee for creating this pull request!

A maintainer will review your changes shortly. Please don't be discouraged if it takes a while.

While you wait, make sure to review our contributor guidelines.

Tip

Need help or want to ask for a PR review to be expedited?

Join us on Slack in the #pr-reviews channel.

@mergify mergify bot removed the conflict This PR has conflicts label Mar 11, 2024
@Gowiem Gowiem removed the stale This PR has gone stale label Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@r351574nc3 r351574nc3 Awaiting requested review from r351574nc3 r351574nc3 is a code owner automatically assigned from cloudposse/contributors

@srhopkins srhopkins Awaiting requested review from srhopkins srhopkins is a code owner automatically assigned from cloudposse/contributors

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ChrisMcKee @hans-d @Gowiem @cloudpossebot