Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to use the Security Group module #138

Merged
merged 8 commits into from
Dec 29, 2021
Merged

Update to use the Security Group module #138

merged 8 commits into from
Dec 29, 2021

Conversation

aknysh
Copy link
Member

@aknysh aknysh commented Dec 29, 2021

what

  • Update to use the Security Group module
  • Add migration doc
  • Update README and GitHub workflows

why

@aknysh aknysh added the patch A minor, backward compatible change label Dec 29, 2021
@aknysh aknysh self-assigned this Dec 29, 2021
@aknysh aknysh requested review from a team as code owners December 29, 2021 03:02
@aknysh
Copy link
Member Author

aknysh commented Dec 29, 2021

/test all

@aknysh
Copy link
Member Author

aknysh commented Dec 29, 2021

/test all

@aknysh
Copy link
Member Author

aknysh commented Dec 29, 2021

/test all

@aknysh
Copy link
Member Author

aknysh commented Dec 29, 2021

/test all

max-lobur
max-lobur previously approved these changes Dec 29, 2021
View reviewed changes
Copy link
Contributor

@max-lobur max-lobur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest naming security-group-variables.tf
Similar to spotinst and other feature-specific things

@aknysh
Copy link
Member Author

aknysh commented Dec 29, 2021

/test all

@aknysh
Copy link
Member Author

aknysh commented Dec 29, 2021

I suggest naming security-group-variables.tf Similar to spotinst and other feature-specific things

Nice find @max-lobur .
I've renamed the file.
We need to use the pattern for consistency.

@aknysh aknysh merged commit e738650 into master Dec 29, 2021
@aknysh aknysh deleted the update-sg branch December 29, 2021 16:16
@z0rc z0rc mentioned this pull request Jan 6, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@max-lobur max-lobur max-lobur approved these changes

@Makeshift Makeshift Awaiting requested review from Makeshift Makeshift was automatically assigned from cloudposse/contributors

@dylanbannon dylanbannon Awaiting requested review from dylanbannon dylanbannon was automatically assigned from cloudposse/contributors

@Nuru Nuru Awaiting requested review from Nuru

@osterman osterman Awaiting requested review from osterman

@korenyoni korenyoni Awaiting requested review from korenyoni

@nitrocode nitrocode Awaiting requested review from nitrocode

Assignees

@aknysh aknysh

Labels
patch A minor, backward compatible change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aknysh @max-lobur