Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add create_before_destroy lifecycle to sg #111

Merged
merged 3 commits into from
Feb 25, 2021
Merged

Add create_before_destroy lifecycle to sg #111

merged 3 commits into from
Feb 25, 2021

Conversation

nitrocode
Copy link
Member

@nitrocode nitrocode commented Feb 25, 2021

what

  • Add name_prefix and lifecycle to sg

why

  • Name changes to the security group may not be able to be destroyed easily.

references

note

Unsure if both the lifecycle and the name_prefix args need to be set. Might be good enough just to do the lifecycle.

I'm thinking it might be better to remove the name_prefix and see if the lifecycle clears the issue for the user.

@nitrocode nitrocode requested review from a team as code owners February 25, 2021 01:32
@nitrocode
Copy link
Member Author

/test all

@SweetOps SweetOps added the patch A minor, backward compatible change label Feb 25, 2021
@SweetOps SweetOps changed the title Add name_prefix and lifecycle to sg Add create_before_destroy lifecycle to sg Feb 25, 2021
@SweetOps SweetOps merged commit a55f22c into master Feb 25, 2021
@SweetOps SweetOps deleted the sg_lifecycle branch February 25, 2021 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch A minor, backward compatible change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants