Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add input variable for ecs service wait_for_steady_state #109

Merged
merged 4 commits into from
Feb 25, 2021
Merged

Add input variable for ecs service wait_for_steady_state #109

merged 4 commits into from
Feb 25, 2021

Conversation

nitrocode
Copy link
Member

what

  • Add input variable for ecs service wait_for_steady_state
  • Defaults to false which is the default on the aws_ecs_service resource

why

  • Allows the module to wait until the service is in a steady state before applying successfully

references

@nitrocode nitrocode requested review from a team as code owners February 24, 2021 23:47
@nitrocode nitrocode requested a review from a team as a code owner February 24, 2021 23:48
@nitrocode nitrocode requested review from adamcrews and joe-niland and removed request for a team February 24, 2021 23:48
@nitrocode
Copy link
Member Author

/test all

1 similar comment
@nitrocode
Copy link
Member Author

/test all

@mergify
Copy link

mergify bot commented Feb 25, 2021

This pull request is now in conflict. Could you fix it @nitrocode? 🙏

@nitrocode
Copy link
Member Author

/test all

@jamengual jamengual merged commit a4d023d into master Feb 25, 2021
@jamengual jamengual deleted the wait_for_steady_state branch February 25, 2021 01:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamengual jamengual jamengual approved these changes

@adamcrews adamcrews Awaiting requested review from adamcrews

@joe-niland joe-niland Awaiting requested review from joe-niland

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nitrocode @jamengual @cloudpossebot