-
-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes deprecation of log_group_name -> log_destination #13
Conversation
Fixes several warnings around wildcarding
Fixes outputs which return as lists
Removes current = “true” from aws_region
Removes current = “true” from aws_region
Fixes deprecation of log_group_name -> log_destination
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @slmingol
please see comments.
Also, can you please update the outputs to use the splat+join
syntax - our test throws the error Warning: output "log_group_arn": must use splat syntax to access aws_cloudwatch_log_group.default attribute "arn", because it has "count" set
also, please run terraform fmt
and rebuild README by executing
make init
make readme/deps
make readme
thanks
@slmingol could you address the comments, please? |
Need more detailed steps on what you guys want me to do. Not really following and have tried to delve into your Makefile targets and got completely lost. Keep in mind that not all of us are familiar w/ your CI/CD process 8-). For e.g.:
|
@slmingol may be you just forgot to commit your changes. you marked Andrew's comments as resolved, but there is no commit to address |
@maximmi - yeah I didn't understand what Andrew was asking me to do on the outputs. I hadn't resolved the comment - #13 (review) where he asked for them. Just wasn't sure what to do to satisfy what he was asking for for the splat+join and the other changes. |
@maximmi so one issue I'm seeing is that on MacOS some of us will have gawk installed via brew. It adds both awk/gawk to your $PATH which results in this line in the file:
That first line to |
@aknysh - can you explain what outputs to fix? The outputs.tf has the splat+join from what I can tell:
|
@slmingol |
@aknysh - OK resolved conflicts. |
@aknysh sorry for being a noob, I now realize that you guys have Travis running at the bottom telling me what's failing, I've resolved the checks, lmk if you want all this squashed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @slmingol
No description provided.