Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix exception causes in cloudpickle.py #379

Merged
merged 1 commit into from
Jun 16, 2020
Merged

Conversation

cool-RR
Copy link
Contributor

@cool-RR cool-RR commented Jun 12, 2020

I recently went over Matplotlib, Pandas and NumPy, fixing a small mistake in the way that Python 3's exception chaining is used. If you're interested, I can do it here too. I've done it on just one file right now.

The mistake is this: In some parts of the code, an exception is being caught and replaced with a more user-friendly error. In these cases the syntax raise new_error from old_error needs to be used.

Python 3's exception chaining means it shows not only the traceback of the current exception, but that of the original exception (and possibly more.) This is regardless of raise from. The usage of raise from tells Python to put a more accurate message between the tracebacks. Instead of this:

During handling of the above exception, another exception occurred:

You'll get this:

The above exception was the direct cause of the following exception:

The first is inaccurate, because it signifies a bug in the exception-handling code itself, which is a separate situation than wrapping an exception.

Let me know what you think!

@codecov
Copy link

codecov bot commented Jun 12, 2020

Codecov Report

Merging #379 into master will not change coverage.
The diff coverage is 33.33%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #379   +/-   ##
=======================================
  Coverage   92.91%   92.91%           
=======================================
  Files           2        2           
  Lines         805      805           
  Branches      164      164           
=======================================
  Hits          748      748           
  Misses         29       29           
  Partials       28       28           
Impacted Files Coverage Δ
cloudpickle/cloudpickle.py 91.76% <33.33%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0c0b8d4...3004f73. Read the comment docs.

@jakirkham jakirkham requested a review from ogrisel June 15, 2020 17:27
@jakirkham
Copy link
Member

Seems ok to me. Let's see what others say 🙂

@ogrisel
Copy link
Contributor

ogrisel commented Jun 16, 2020

LGTM as well. Thanks very much @cool-RR.

@ogrisel ogrisel merged commit e2fcfeb into cloudpipe:master Jun 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants