added hooks and spec file for dynatrace #109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
modified test to fit logenv scenario fixed download url to include nodejs agent getting process agent path from manifest.json now added error handling for agentpath() and fixed some returns fixed wrong paths in returns fixed return paths fixed dynatrace-env.sh path removed cf_spec since it's not used anymore in upstream added detection for multiple services added debug output to service detection clarified log output added integration tests for dynatrace agent changed url adapted urls to new format, added test for service detection added hook test includes removed pointless checks added services cleanup improved error message and var names, removed pointless '/' added test for incomplete dynatrace service added skiperrors flag and needed tests made check for skiperrors a bit nicer
|
Hey arthfl! Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you and the commit authors have already signed the CLA. |
|
We have created an issue in Pivotal Tracker to manage this: https://www.pivotaltracker.com/story/show/151873095 The labels on this github issue will be updated when the story is started. |
|
Thanks @arthfl, prioritized for review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added integration for the Dynatrace PaaS agent.
This includes a flag that enables customers/users to skip the installation without an error if the download of the installer fails for some reason. When something goes wrong during the installation process itself, if still fails with an error. And the default is still to exit with an error, this was only added to give customers the possibility to prevent crashing apps if the download fails for some reason (network problem, wrong version requested...etc)
The integration is pretty similar to the still existing one in the staticfile buildpack.
An explanation of the use cases your change solves:
This enables CloudFoundry users to monitor their apps with the Dynatrace PaaS agent.
I have viewed signed and have submitted the Contributor License Agreement
I have made this pull request to the
developbranchI have added an integration test