Credentials in VCAP_SERVICES are objects #3162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
georgethebeatle
previously approved these changes
Mar 12, 2024
rather than map[string]string Issue: #2900 Co-authored-by: Danail Branekov <danailster@gmail.com> Co-authored-by: Georgi Sabev <georgethebeatle@gmail.com>
georgethebeatle
force-pushed
the
issues/2900-object-credentials-vcap-services
branch
from
9284b77
to
21f93ae
Compare
georgethebeatle
approved these changes
Mar 13, 2024
georgethebeatle
deleted the
issues/2900-object-credentials-vcap-services
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is there a related GitHub Issue?
#2900
What is this change about?
Fix VCAP_SERVICES env var format: service binding credentials are objects, not string key value pairs
Does this PR introduce a breaking change?
No