Add "guids" as a valid package list filter #3142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- The latest version of the CF CLI (v8.7.8) introduced a change where the 'StagePackage' function now uses the "guids" query parameter when listing packages for an app. Korifi did not support this parameter, even though it claimed to support API v3.117.0. Co-authored-by: Dave Walter <walterda@vmware.com>
davewalter
force-pushed
the
add-guid-filter-to-package-list
branch
from
ee5c00b
to
0864507
Compare
acosta11
approved these changes
Feb 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is there a related GitHub Issue?
No
What is this change about?
The latest version of the CF CLI (v8.7.8) introduced a change where the 'StagePackage' function now uses the "guids" query parameter when listing packages for an app. Korifi did not support this parameter, even though it claimed to support API v3.117.0.
This call is made by the CLI when an application is pushed with the
--no-startoption and then started withcf start.Does this PR introduce a breaking change?
No. It fixes a compatibility issue with CF CLI v8.7.8.
Acceptance Steps
Install CF CLI v8.7.8 and attempt to
cf pushan application.Tag your pair, your PM, and/or team
@acosta11