-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[bug] app restart should be synchronous #3036
Labels
bug
Something isn't working
Comments
danail-branekov
changed the title
[bug] app restart is asynchronous
[bug] app restart should be synchronous
Dec 8, 2023
danail-branekov
added a commit
that referenced
this issue
Apr 5, 2024
* Introduce `CFApp.Status.ActualState` to reflect the actual state of the app. The start/stop/restart operations waits for that field to become equal to the desired app state * Introduce `CFProcess.Status.ActualInstances` to reflect the actual app workload instances * Introduce `AppWorkload.Status.ActualInstances` to reflect the actual statefulset replicas * The state chain is tested by a test in the `crds` suite * The existing crd test is deleted as it has become obsolete by the test above fixes #3036 Co-authored-by: Georgi Sabev <georgethebeatle@gmail.com>
danail-branekov
added a commit
that referenced
this issue
Apr 5, 2024
* Introduce `CFApp.Status.ActualState` to reflect the actual state of the app. The start/stop/restart operations waits for that field to become equal to the desired app state * Introduce `CFProcess.Status.ActualInstances` to reflect the actual app workload instances * Introduce `AppWorkload.Status.ActualInstances` to reflect the actual statefulset replicas * The state chain is tested by a test in the `crds` suite * The existing crd test is deleted as it has become obsolete by the test above fixes #3036 Co-authored-by: Georgi Sabev <georgethebeatle@gmail.com>
danail-branekov
added a commit
that referenced
this issue
Apr 5, 2024
* Introduce `CFApp.Status.ActualState` to reflect the actual state of the app. The start/stop/restart operations waits for that field to become equal to the desired app state * Introduce `CFProcess.Status.ActualInstances` to reflect the actual app workload instances * Introduce `AppWorkload.Status.ActualInstances` to reflect the actual statefulset replicas * The state chain is tested by a test in the `crds` suite * The existing crd test is deleted as it has become obsolete by the test above fixes #3036 Co-authored-by: Georgi Sabev <georgethebeatle@gmail.com>
danail-branekov
added a commit
that referenced
this issue
Apr 8, 2024
* Introduce `CFApp.Status.ActualState` to reflect the actual state of the app. The start/stop/restart operations waits for that field to become equal to the desired app state * Introduce `CFProcess.Status.ActualInstances` to reflect the actual app workload instances * Introduce `AppWorkload.Status.ActualInstances` to reflect the actual statefulset replicas * The state chain is tested by a test in the `crds` suite * The existing crd test is deleted as it has become obsolete by the test above fixes #3036 Co-authored-by: Georgi Sabev <georgethebeatle@gmail.com>
danail-branekov
added a commit
that referenced
this issue
Apr 8, 2024
* Introduce `CFApp.Status.ActualState` to reflect the actual state of the app. The start/stop/restart operations waits for that field to become equal to the desired app state * Introduce `CFProcess.Status.ActualInstances` to reflect the actual app workload instances * Introduce `AppWorkload.Status.ActualInstances` to reflect the actual statefulset replicas * The state chain is tested by a test in the `crds` suite * The existing crd test is deleted as it has become obsolete by the test above fixes #3036 Co-authored-by: Georgi Sabev <georgethebeatle@gmail.com>
danail-branekov
added a commit
that referenced
this issue
Apr 8, 2024
* Introduce `CFApp.Status.ActualState` to reflect the actual state of the app. The start/stop/restart operations waits for that field to become equal to the desired app state * Introduce `CFProcess.Status.ActualInstances` to reflect the actual app workload instances * Introduce `AppWorkload.Status.ActualInstances` to reflect the actual statefulset replicas * The state chain is tested by a test in the `crds` suite * The existing crd test is deleted as it has become obsolete by the test above fixes #3036 Co-authored-by: Georgi Sabev <georgethebeatle@gmail.com>
danail-branekov
added a commit
that referenced
this issue
Apr 9, 2024
* Introduce `CFApp.Status.ActualState` to reflect the actual state of the app. The start/stop/restart operations waits for that field to become equal to the desired app state * Introduce `CFProcess.Status.ActualInstances` to reflect the actual app workload instances * Introduce `AppWorkload.Status.ActualInstances` to reflect the actual statefulset replicas * The state chain is tested by a test in the `crds` suite * The existing crd test is deleted as it has become obsolete by the test above fixes #3036 Co-authored-by: Georgi Sabev <georgethebeatle@gmail.com>
georgethebeatle
added a commit
that referenced
this issue
Apr 9, 2024
* Introduce `CFApp.Status.ActualState` to reflect the actual state of the app. The start/stop/restart operations waits for that field to become equal to the desired app state * Introduce `CFProcess.Status.ActualInstances` to reflect the actual app workload instances * Introduce `AppWorkload.Status.ActualInstances` to reflect the actual statefulset replicas * The state chain is tested by a test in the `crds` suite * The existing crd test is deleted as it has become obsolete by the test above fixes #3036 Co-authored-by: Georgi Sabev <georgethebeatle@gmail.com>
georgethebeatle
added a commit
that referenced
this issue
Apr 9, 2024
* Introduce `CFApp.Status.ActualState` to reflect the actual state of the app. The start/stop/restart operations waits for that field to become equal to the desired app state * Introduce `CFProcess.Status.ActualInstances` to reflect the actual app workload instances * Introduce `AppWorkload.Status.ActualInstances` to reflect the actual statefulset replicas * The state chain is tested by a test in the `crds` suite * The existing crd test is deleted as it has become obsolete by the test above fixes #3036 Co-authored-by: Georgi Sabev <georgethebeatle@gmail.com>
georgethebeatle
added a commit
that referenced
this issue
Apr 9, 2024
* Introduce `CFApp.Status.ActualState` to reflect the actual state of the app. The start/stop/restart operations waits for that field to become equal to the desired app state * Introduce `CFProcess.Status.ActualInstances` to reflect the actual app workload instances * Introduce `AppWorkload.Status.ActualInstances` to reflect the actual statefulset replicas * The state chain is tested by a test in the `crds` suite * The existing crd test is deleted as it has become obsolete by the test above fixes #3036 Co-authored-by: Georgi Sabev <georgethebeatle@gmail.com>
georgethebeatle
added a commit
that referenced
this issue
Apr 9, 2024
* Introduce `CFApp.Status.ActualState` to reflect the actual state of the app. The start/stop/restart operations waits for that field to become equal to the desired app state * Introduce `CFProcess.Status.ActualInstances` to reflect the actual app workload instances * Introduce `AppWorkload.Status.ActualInstances` to reflect the actual statefulset replicas * The state chain is tested by a test in the `crds` suite * The existing crd test is deleted as it has become obsolete by the test above fixes #3036 Co-authored-by: Georgi Sabev <georgethebeatle@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
According to cf api docs on app restart,
In Korifi, however, app restart is currently implemented by setting the desired state to stopped and then back to started without actually waiting for the app go down and then up.
This bug is most probably exposed by this flake
The text was updated successfully, but these errors were encountered: