Cherrypick CCV3 internal router simplication - ad368258f69784e799d08a… #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author: Merric De Launey <mdelauney@pivotal.io>
Date: Thu Jul 9 21:04:52 2020 +0000
Simplify CCV3 internal router
- Now, we don't need to hit `/v3` before every command to populate the
router. Instead, we have just written the resource names directly into
the routes file.
- Refactor the routes file to be a map keyed by route name, instead of
an array of routes that gets later converted into a map on the fly.
- The `GetInfo()` method now does not return `ccv3.ResourceLinks`,
because we don't hit `/v3`.
Slack discussion where we asked if anyone knew why it was so complicated
(and nobody really knew):
https://cloudfoundry.slack.com/archives/C032824SM/p1594316115396400
Co-authored-by: Merric De Launey <mdelauney@pivotal.io>
Co-authored-by: Reid Mitchell <rmitchell@pivotal.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry picked ad36825
Author: Merric De Launey mdelauney@pivotal.io
Date: Thu Jul 9 21:04:52 2020 +0000
Simplify CCV3 internal router
Thank you for contributing to the CF CLI! Please read the following: