Add bun support #188
Merged
Add bun support #188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @simpleauthority! Happy to accept this PR, but I just merged #190 which refactored some of the package manager stuff. Could you please rebase and port your changes over? All of the package manager logic is now in Also, please run |
|
Sure thing, I will take a look. |
jacobsandersen
force-pushed
the
feat/add-bun-support
branch
from
4d23d2e
to
779191a
Compare
|
Rebased, tests all pass, was able to deploy my website with this, and added the changeset. Let me know if you need anything else @1000hz. Thanks! |
1000hz
reviewed
Oct 10, 2023
1000hz
approved these changes
Oct 10, 2023
|
Oh, one more thing I just realized before I merge. Could you add |
|
Done! |
1000hz
approved these changes
Oct 10, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds Bun support and closes #187.
I wrote the PR before I read the contributing guidelines (sorry) and did not make an issue before I started working. As such, if you decline this it's not a big deal.
However, worth noting, it does work and I can deploy my website to CF pages with this.