Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude vitest.config.mts from hello world template types #6333

Merged
merged 2 commits into from
Jul 25, 2024

Conversation

penalosa
Copy link
Contributor

@penalosa penalosa commented Jul 25, 2024

What this PR solves / how to test

Exclude vitest.config.mts from C3's Hello World worker. Previously, this was in the same typing environment as the user-worker code, causing @types/node to be transitively pulled in. This caused breakage because of cloudflare/workerd#1298.

Fixes #6328

Author has addressed the following

  • Tests
    • TODO (before merge)
    • Included
    • Not necessary because: Minor typing change
  • E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required / Maybe required
    • Not required because: Minor typing change
  • Changeset (Changeset guidelines)
    • TODO (before merge)
    • Included
    • Not necessary because:
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Not necessary because: Bugfix

@penalosa penalosa requested a review from a team as a code owner July 25, 2024 00:39
Copy link

changeset-bot bot commented Jul 25, 2024

🦋 Changeset detected

Latest commit: 1816648

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
create-cloudflare Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10086134673/npm-package-wrangler-6333

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/6333/npm-package-wrangler-6333

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10086134673/npm-package-wrangler-6333 dev path/to/script.js
Additional artifacts:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10086134673/npm-package-create-cloudflare-6333 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10086134673/npm-package-cloudflare-kv-asset-handler-6333
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10086134673/npm-package-miniflare-6333
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10086134673/npm-package-cloudflare-pages-shared-6333
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10086134673/npm-package-cloudflare-vitest-pool-workers-6333

Note that these links will no longer work once the GitHub Actions artifact expires.


wrangler@3.66.0 includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20240718.0
workerd 1.20240718.0 1.20240718.0
workerd --version 1.20240718.0 2024-07-18

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

Copy link
Contributor

@petebacondarwin petebacondarwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're a star for fixing this @penalosa - cheers.

@petebacondarwin petebacondarwin merged commit affdc56 into main Jul 25, 2024
23 checks passed
@petebacondarwin petebacondarwin deleted the penalosa/fix-hello-types branch July 25, 2024 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
2 participants