Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[C3] chore: update qwik template to use getPlatformProxy #5010

Merged
merged 1 commit into from
Feb 14, 2024

Conversation

dario-piotrowicz
Copy link
Member

@dario-piotrowicz dario-piotrowicz commented Feb 14, 2024

What this PR solves / how to test:

This PR updates the C3 Qwik template to use the getPlatformProxy utility instead of the deprecated getBindingsProxy one

Author has addressed the following:

Note for PR author:

We want to celebrate and highlight awesome PR review! If you think this PR received a particularly high-caliber review, please assign it the label highlight pr review so future reviewers can take inspiration and learn from it.

@dario-piotrowicz dario-piotrowicz requested a review from a team as a code owner February 14, 2024 00:09
Copy link

changeset-bot bot commented Feb 14, 2024

🦋 Changeset detected

Latest commit: 4c17df7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
create-cloudflare Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7894438129/npm-package-wrangler-5010

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/5010/npm-package-wrangler-5010

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7894438129/npm-package-wrangler-5010 dev path/to/script.js
Additional artifacts:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7894438129/npm-package-create-cloudflare-5010 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7894438129/npm-package-cloudflare-kv-asset-handler-5010
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7894438129/npm-package-miniflare-5010
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7894438129/npm-package-cloudflare-pages-shared-5010

Note that these links will no longer work once the GitHub Actions artifact expires.


wrangler@3.28.2 includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20240129.2
workerd 1.20240129.0 1.20240129.0
workerd --version 1.20240129.0 2024-01-29

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

Copy link

codecov bot commented Feb 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ce6d4bc) 70.43% compared to head (4c17df7) 70.49%.
Report is 3 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5010      +/-   ##
==========================================
+ Coverage   70.43%   70.49%   +0.06%     
==========================================
  Files         297      297              
  Lines       15419    15419              
  Branches     3949     3949              
==========================================
+ Hits        10860    10870      +10     
+ Misses       4559     4549      -10     

see 7 files with indirect coverage changes

Copy link
Contributor

@IgorMinar IgorMinar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. thanks @dario-piotrowicz

@dario-piotrowicz dario-piotrowicz merged commit 9f78704 into main Feb 14, 2024
22 checks passed
@dario-piotrowicz dario-piotrowicz deleted the qwik-getplatformproxy branch February 14, 2024 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants