Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wrangler] Backport recent inspector proxy server changes to V2 #4587

Merged
merged 2 commits into from
Dec 12, 2023

Conversation

mrbbot
Copy link
Contributor

@mrbbot mrbbot commented Dec 11, 2023

What this PR solves / how to test:

This PR backports some changes we recently made to the Wrangler 3's inspector proxy to Wrangler 2. Specifically, the inspector server now listens on local interfaces by default, and validates incoming Host/Origin headers.

Author has addressed the following:

  • Tests
    • Included
    • Not necessary because: these changes have already landed in v3, and we're just backporting them over to a version that's just receiving security updates
  • Changeset (Changeset guidelines)
    • Included
    • Not necessary because:
  • Associated docs
    • Issue(s)/PR(s):
    • Not necessary because: v2 is no longer documented

Note for PR author:

We want to celebrate and highlight awesome PR review! If you think this PR received a particularly high-caliber review, please assign it the label highlight pr review so future reviewers can take inspiration and learn from it.

@mrbbot mrbbot requested a review from a team as a code owner December 11, 2023 18:03
Copy link

changeset-bot bot commented Dec 11, 2023

🦋 Changeset detected

Latest commit: ab6c4cb

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
wrangler Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented Dec 12, 2023

Codecov Report

❗ No coverage uploaded for pull request base (v2-maintenance@84f4276). Click here to learn what that means.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                @@
##             v2-maintenance    #4587   +/-   ##
=================================================
  Coverage                  ?   74.52%           
=================================================
  Files                     ?      179           
  Lines                     ?    10940           
  Branches                  ?     2911           
=================================================
  Hits                      ?     8153           
  Misses                    ?     2787           
  Partials                  ?        0           

@mrbbot mrbbot merged commit 49a4696 into v2-maintenance Dec 12, 2023
11 checks passed
@mrbbot mrbbot deleted the bcoll/v2-inspector-changes-backport branch December 12, 2023 16:10
@github-actions github-actions bot mentioned this pull request Dec 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants