Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix C3 e2e tests for Angular #4403

Merged
merged 1 commit into from
Nov 8, 2023
Merged

test: fix C3 e2e tests for Angular #4403

merged 1 commit into from
Nov 8, 2023

Conversation

petebacondarwin
Copy link
Contributor

Sorry for breaking C3 e2e tests on main.

@petebacondarwin petebacondarwin requested a review from a team as a code owner November 8, 2023 12:47
Copy link

changeset-bot bot commented Nov 8, 2023

🦋 Changeset detected

Latest commit: da95355

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
create-cloudflare Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Nov 8, 2023

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/6798429037/npm-package-wrangler-4403

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/6798429037/npm-package-wrangler-4403

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/6798429037/npm-package-wrangler-4403 dev path/to/script.js
Additional artifacts:
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/6798429037/npm-package-miniflare-4403
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/6798429037/npm-package-cloudflare-pages-shared-4403

Note that these links will no longer work once the GitHub Actions artifact expires.


wrangler@3.15.0 includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20231025.1
workerd 1.20231030.0 1.20231030.0
workerd --version 1.20231030.0 2023-10-30

|

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

Copy link

codecov bot commented Nov 8, 2023

Codecov Report

Merging #4403 (da95355) into main (789491b) will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4403      +/-   ##
==========================================
+ Coverage   75.28%   75.31%   +0.03%     
==========================================
  Files         223      223              
  Lines       12357    12357              
  Branches     3198     3198              
==========================================
+ Hits         9303     9307       +4     
+ Misses       3054     3050       -4     

see 3 files with indirect coverage changes

@petebacondarwin petebacondarwin merged commit cb8ec90 into main Nov 8, 2023
24 of 27 checks passed
@petebacondarwin petebacondarwin deleted the fix-angular-e2e branch November 8, 2023 16:01
@workers-devprod workers-devprod mentioned this pull request Nov 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants