Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove unneeded polyfills from the Angular template #4339

Merged
merged 2 commits into from
Nov 7, 2023

Conversation

alan-agius4
Copy link
Contributor

@alan-agius4 alan-agius4 commented Nov 3, 2023

performance.mark and global polyfills are no longer needed in a v17 application.

See: angular/angular#52505

Copy link

changeset-bot bot commented Nov 3, 2023

🦋 Changeset detected

Latest commit: da76e11

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
create-cloudflare Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@alan-agius4 alan-agius4 changed the title refactor: remove unneeded polyfills from the Angular template fix: remove unneeded polyfills from the Angular template Nov 3, 2023
`performance.mark` and `global` polyfills are no longer needed in a v17 application.
@alan-agius4 alan-agius4 marked this pull request as ready for review November 7, 2023 06:23
@alan-agius4 alan-agius4 requested a review from a team as a code owner November 7, 2023 06:23
Copy link
Contributor

@petebacondarwin petebacondarwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet! I'll give it a try locally before we merge.

Copy link
Contributor

github-actions bot commented Nov 7, 2023

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/6782844954/npm-package-wrangler-4339

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/6782844954/npm-package-wrangler-4339

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/6782844954/npm-package-wrangler-4339 dev path/to/script.js
Additional artifacts:
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/6782844954/npm-package-miniflare-4339
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/6782844954/npm-package-cloudflare-pages-shared-4339

Note that these links will no longer work once the GitHub Actions artifact expires.


wrangler@3.15.0 includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20231025.1
workerd 1.20231030.0 1.20231030.0
workerd --version 1.20231030.0 2023-10-30

|

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

Copy link

codecov bot commented Nov 7, 2023

Codecov Report

Merging #4339 (da76e11) into main (675d216) will increase coverage by 0.01%.
Report is 5 commits behind head on main.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4339      +/-   ##
==========================================
+ Coverage   75.35%   75.36%   +0.01%     
==========================================
  Files         223      223              
  Lines       12341    12344       +3     
  Branches     3190     3193       +3     
==========================================
+ Hits         9299     9303       +4     
+ Misses       3042     3041       -1     

see 10 files with indirect coverage changes

@petebacondarwin petebacondarwin self-assigned this Nov 7, 2023
@petebacondarwin
Copy link
Contributor

Works well locally! I had to fix a formatting issue. But once the CI is green we can merge.

@petebacondarwin petebacondarwin merged commit 33bd75d into cloudflare:main Nov 7, 2023
23 of 27 checks passed
@alan-agius4 alan-agius4 deleted the performance-mark branch November 7, 2023 10:50
@workers-devprod workers-devprod mentioned this pull request Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants