Remove extension name check when generating response

* Fix #2779
cloudflare · Sep 28, 2023 · 41294df · 41294df
1 parent 78e9397
commit 41294df
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 6 deletions.
diff --git a/.changeset/cold-bugs-kick.md b/.changeset/cold-bugs-kick.md
@@ -0,0 +1,7 @@
+---
+"@cloudflare/pages-shared": minor
+---
+
+fix: remove extension name check when generating response
+
+Current regex logic to check whether a pathname is a file (has file extension) is causing trouble for some websites, and now \${pathname}/index.html is always checked before returning notFound().
diff --git a/packages/pages-shared/asset-server/handler.ts b/packages/pages-shared/asset-server/handler.ts
@@ -293,8 +293,6 @@ export async function generateHandler<
 			);
 		} else if ((assetEntry = await findAssetEntryForPath(`${pathname}.html`))) {
 			return serveAsset(assetEntry);
-		} else if (hasFileExtension(pathname)) {
-			return notFound();
 		}
 
 		if ((assetEntry = await findAssetEntryForPath(`${pathname}/index.html`))) {
@@ -626,10 +624,6 @@ function isCacheable(request: Request) {
 	return !request.headers.has("authorization") && !request.headers.has("range");
 }
 
-function hasFileExtension(path: string) {
-	return /\/.+\.[a-z0-9]+$/i.test(path);
-}
-
 // Parses a request URL hostname to determine if the request
 // is from a project served in "preview" mode.
 function isPreview(url: URL): boolean {