Assorted CI dependency cleanup

[fhanau]

See details in the commit descriptions. Note: This removes esbuild which appears to be unused but might be useful for future JS/TS work, feel free to add it back if needed or lmk if you want to keep it.

[jasnell]

@mrbbot .. are y'all using the esbuild dependency here?

[mrbbot]

We use esbuild in the npm release workflow...

workerd/.github/workflows/npm.yml

Lines 106 to 120 in 875a517

	- name: Build node-install
	run: npx esbuild npm/lib/node-install.ts --outfile=npm/workerd/install.js --bundle --target=node16 --define:LATEST_COMPATIBILITY_DATE="\"${LATEST_COMPATIBILITY_DATE}\"" --define:WORKERD_VERSION="\"${WORKERD_VERSION}\"" --platform=node --external:workerd --log-level=warning
	env:
	WORKERD_VERSION: ${{ needs.version.outputs.version }}
	LATEST_COMPATIBILITY_DATE: ${{ needs.version.outputs.date }}
	- name: Build node-shim
	run: npx esbuild npm/lib/node-shim.ts --outfile=npm/workerd/bin/workerd --bundle --target=node16 --define:LATEST_COMPATIBILITY_DATE="\"${LATEST_COMPATIBILITY_DATE}\"" --define:WORKERD_VERSION="\"${WORKERD_VERSION}\"" --platform=node --external:workerd --log-level=warning
	env:
	WORKERD_VERSION: ${{ needs.version.outputs.version }}
	LATEST_COMPATIBILITY_DATE: ${{ needs.version.outputs.date }}
	- name: Build node-path
	run: npx esbuild npm/lib/node-path.ts --outfile=npm/workerd/lib/main.js --bundle --target=node16 --define:LATEST_COMPATIBILITY_DATE="\"${LATEST_COMPATIBILITY_DATE}\"" --define:WORKERD_VERSION="\"${WORKERD_VERSION}\"" --platform=node --external:workerd --log-level=warning
	env:
	WORKERD_VERSION: ${{ needs.version.outputs.version }}
	LATEST_COMPATIBILITY_DATE: ${{ needs.version.outputs.date }}

...but these are all prefixed with npx, and I can't see a pnpm install in that workflow, so I'm not actually sure if the version in package.json is used. Ideally it would be though.

[fhanau]

Sounds like there is at least potential value in retaining esbuild... Updated the PR to drop that patch for now.