Log Actor ID on V8 deserialization errors #1354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I’m going to want to put things in the SetupParams struct that must be moved out in order to be used. As such, some of the things in the params member would be valid and some things would be invalid after running the constructor. Rather than have to document this mess, it’s better to treat the SetupParams as something only the constructor has access to and save away everything else we need other data member.
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
jasnell
reviewed
Oct 26, 2023
jasnell
reviewed
Oct 26, 2023
jasnell
reviewed
Oct 26, 2023
jasnell
reviewed
Oct 26, 2023
bcaimano
approved these changes
Oct 26, 2023
|
I have read the CLA Document and I hereby sign the CLA |
|
recheck |
justin-mp
force-pushed
the
log-actor-on-error
branch
from
4ce3b95
to
d991cdf
Compare
I will need to put things in the SetupParams struct that are only moveable. As such, we’ll want the params parameter to be an rvalue reference so the compiler can give us hints to move the struct into place.
I’m going to want to use this to make an Actor stub in a test.
I need to test something that requires IoContexts that have Actors associated with them. The easiest way to do this was to extend the TestFixture to create a stubbed out Actor for us.
When V8 deserialization fails, it’s likely due to corruption somewhere between the Actor in JS and the storage layer. In order to aid debugging, log the actor id if we know of one.
justin-mp
force-pushed
the
log-actor-on-error
branch
from
d991cdf
to
2bdbe17
Compare
|
be056d0 included in the push should fix the CI problems. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When V8 deserialization fails, it’s likely due to corruption somewhere
between the Actor in JS and the storage layer. In order to aid
debugging, log the actor id if we know of one.