Add back authorizationUrl redirect feature with a flag
#828
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 621211d.
Signed-off-by: Wayne Zhang <qiwzhang@google.com>
nareddyt
previously approved these changes
Jan 15, 2021
start_esp/start_esp.py
Outdated
| @@ -939,6 +940,11 @@ def make_argparser(): | |||
| parser.add_argument('--jwks_cache_duration_in_s', default=None, type=int, help=''' | |||
| Specify JWT public key cache duration in seconds. Default is 5 minutes.''') | |||
|
|
|||
| parser.add_argument('--redirect_authorization_url', action='store_true', | |||
There was a problem hiding this comment.
Nit: enable_redirect_to_authorization_url
Current name makes it sound like the flag accepts a URL string as a param.
There was a problem hiding this comment.
how about
--enable_jwt_authorization_url_redirect
TAOXUY
reviewed
Jan 15, 2021
TAOXUY
reviewed
Jan 15, 2021
Signed-off-by: Wayne Zhang <qiwzhang@google.com>
|
PTAL |
TAOXUY
approved these changes
Jan 15, 2021
nareddyt
approved these changes
Jan 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rollbacked the `authorizationUrl" redirect feature removed by #824
Add a new flag --redirect_authorization_url to guard this feature. This feature is only enabled when this flag is specified.