Deprecate x-security #101
Merged
Deprecate x-security #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think some E2E tests are using these swagger files. Will these change impact tests? They have certain ways to generate token. I think these token should match swagger spec. |
|
I will see if I can run them all locally on my machine.
Thanks,
Sarvani
…On Wed, Feb 22, 2017 at 10:11 AM, Wayne Zhang ***@***.***> wrote:
I think some E2E tests are using these swagger files. Will these change
impact tests? They have certain ways to generate token. I think these token
should match swagger spec.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#101 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AXVMhaAvDcUNgqDDeA0cbTovdwHInZ85ks5rfHo8gaJpZM4MI_Ai>
.
--
Thanks,
Sarvani
|
|
t tests should pass without change. But it is better to run them and verify. The only thing that is affected is that, in auth configuration for t tests, the "audiences" field should be moved to "providers" section from "requirements" section. |
|
I will run the t-tests. As discussed, the audiences and the providers is
the proto configuration and that is unrelated to this change. Sebastian
just started the E2E tests on my pull request.
Thanks,
Sarvani
…On Wed, Feb 22, 2017 at 10:47 AM, Limin Wang ***@***.***> wrote:
t tests should pass without change. But it is better to run them and
verify. The only thing that is affected is that, in auth configuration for
t tests, the "audiences" field should be moved to "providers" section from
"requirements" section.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#101 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AXVMhfRgKAyWPZkVXfmMauqJLXT2vhykks5rfIKmgaJpZM4MI_Ai>
.
--
Thanks,
Sarvani
|
liminw
approved these changes
Feb 22, 2017
|
@sebastienvas Are you still using "safe_to_run" label to start Jenkins tests? |
|
No I stopped doing that since the repo is private |
|
Does this need to go into the release? |
qiwzhang
approved these changes
Feb 27, 2017
|
It will be good if this can go into the release since we are removing a
bunch of deprecated fields. But I will leave the decision to experts :-)
+Wayne
…On Mon, Feb 27, 2017 at 12:14 PM, Kuat ***@***.***> wrote:
Does this need to go into the release?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#101 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AXVMhd1pau9PZW6kcT6zDtHWvDb9mMEZks5rgy6wgaJpZM4MI_Ai>
.
--
Thanks,
Sarvani
|
|
These files are some sample swagger json files. Not code change. It is up to you if you want to include it in the release or not. |
sarvaniv
added a commit
that referenced
this pull request
Mar 3, 2017
* Fixed bazel install Change-Id: Ic573e8e4cc2900fa44dfa5c67d6728c58283b649 * Make docker slaves consistent with jenkinsci/slave Change-Id: I6251e93ca7f9e588a552fbf5562d0ec24534480a * Align with latest istio/proxy. (#73) * Support HEAD request in transcoding (#74) * Support HEAD request in transcoding * Removed unused variables * Fixing bazel install for ubuntu salve Change-Id: I184624d166dd49ccd4242f3bcfc54b1182216909 * Use open-sourced scripts (#76) * Use open-sourced scripts * Add a workaround PEX issue * Update to istio/proxy with mixer_client integration. (#78) * Align with istio/proxy. (#79) * Align with istio/proxy. Change-Id: Ic175022bffc559bbc07bea823fde38a5bebc654c * Update go file. Change-Id: If0fd2a52b5b43fecc6b5ec4a1ad2864877de5b17 * Fix debian jessie package issue * Fixes typo in script * Modify test justification. (#83) * Update NGINX to 1.11.9 (#75) * Update NGINX to 1.11.9 * Remove mixer_client repo. (#85) * Revert "Update NGINX to 1.11.9" (#86) * Use grpc-go for interop tests (#88) * fix grpc docker build script (#90) * Upgrade bazel to 0.4.4 (#92) * Upgrade bazel to 0.4.4 * Update istio/proxy for GRPC v1.1.1 (#89) * Fix proxy_flow to align grpc 1.1.1 * Fix ProxyFlow leak (#93) * Basic GRPC request compression support (#94) * Remove undefined flag of Go stress client (#95) * t-test changes to check that x-endpoint-api-userinfo is received by grpc (#96) service. * Fix typo (#97) Change-Id: Idff7a0f23d013f1d67e6cb3c890c54fc0b21ef2e * not to use api_key if service is not activated. (#98) * Escape run description Change-Id: I6a66f9be92314218ee6a19b2d82897b6c55c42d2 * Fix grpc interop stress test script. (#103) * try to escape json again. (#106) * Add t test for fail wrong api key. (#104) Change-Id: I0ea9ed4ba94f13283616eae00b93f067f9c00cf5 * Allow grpc interop stress test fail once. (#105) Change-Id: I5a090eae45c1d9b7d0641b2f09757bb373746aa1 * Update to latest endpoints-tool. (#110) * Deprecate x-security (#101) * Deprecate x-security * Add one more swagger file * Update swagger.yaml file also. * Fix api_key * Fix indentation * Update api keys correctly * Fix indentation * Update CHANGELOG (#112) * Update version number to 1.2.0. (#111)
sarvaniv
added a commit
that referenced
this pull request
Mar 13, 2017
* Fixed bazel install Change-Id: Ic573e8e4cc2900fa44dfa5c67d6728c58283b649 * Make docker slaves consistent with jenkinsci/slave Change-Id: I6251e93ca7f9e588a552fbf5562d0ec24534480a * Align with latest istio/proxy. (#73) * Support HEAD request in transcoding (#74) * Support HEAD request in transcoding * Removed unused variables * Fixing bazel install for ubuntu salve Change-Id: I184624d166dd49ccd4242f3bcfc54b1182216909 * Use open-sourced scripts (#76) * Use open-sourced scripts * Add a workaround PEX issue * Update to istio/proxy with mixer_client integration. (#78) * Align with istio/proxy. (#79) * Align with istio/proxy. Change-Id: Ic175022bffc559bbc07bea823fde38a5bebc654c * Update go file. Change-Id: If0fd2a52b5b43fecc6b5ec4a1ad2864877de5b17 * Fix debian jessie package issue * Fixes typo in script * Modify test justification. (#83) * Update NGINX to 1.11.9 (#75) * Update NGINX to 1.11.9 * Remove mixer_client repo. (#85) * Revert "Update NGINX to 1.11.9" (#86) * Use grpc-go for interop tests (#88) * fix grpc docker build script (#90) * Upgrade bazel to 0.4.4 (#92) * Upgrade bazel to 0.4.4 * Update istio/proxy for GRPC v1.1.1 (#89) * Fix proxy_flow to align grpc 1.1.1 * Fix ProxyFlow leak (#93) * Basic GRPC request compression support (#94) * Remove undefined flag of Go stress client (#95) * t-test changes to check that x-endpoint-api-userinfo is received by grpc (#96) service. * Fix typo (#97) Change-Id: Idff7a0f23d013f1d67e6cb3c890c54fc0b21ef2e * not to use api_key if service is not activated. (#98) * Escape run description Change-Id: I6a66f9be92314218ee6a19b2d82897b6c55c42d2 * Fix grpc interop stress test script. (#103) * try to escape json again. (#106) * Add t test for fail wrong api key. (#104) Change-Id: I0ea9ed4ba94f13283616eae00b93f067f9c00cf5 * Allow grpc interop stress test fail once. (#105) Change-Id: I5a090eae45c1d9b7d0641b2f09757bb373746aa1 * Update to latest endpoints-tool. (#110) * Deprecate x-security (#101) * Deprecate x-security * Add one more swagger file * Update swagger.yaml file also. * Fix api_key * Fix indentation * Update api keys correctly * Fix indentation * Update CHANGELOG (#112) * Update version number to 1.2.0. (#111) * Quick fix of bookstore-server race (#115)
sarvaniv
added a commit
that referenced
this pull request
Apr 10, 2017
* Fixed bazel install Change-Id: Ic573e8e4cc2900fa44dfa5c67d6728c58283b649 * Make docker slaves consistent with jenkinsci/slave Change-Id: I6251e93ca7f9e588a552fbf5562d0ec24534480a * Align with latest istio/proxy. (#73) * Support HEAD request in transcoding (#74) * Support HEAD request in transcoding * Removed unused variables * Fixing bazel install for ubuntu salve Change-Id: I184624d166dd49ccd4242f3bcfc54b1182216909 * Use open-sourced scripts (#76) * Use open-sourced scripts * Add a workaround PEX issue * Update to istio/proxy with mixer_client integration. (#78) * Align with istio/proxy. (#79) * Align with istio/proxy. Change-Id: Ic175022bffc559bbc07bea823fde38a5bebc654c * Update go file. Change-Id: If0fd2a52b5b43fecc6b5ec4a1ad2864877de5b17 * Fix debian jessie package issue * Fixes typo in script * Modify test justification. (#83) * Update NGINX to 1.11.9 (#75) * Update NGINX to 1.11.9 * Remove mixer_client repo. (#85) * Revert "Update NGINX to 1.11.9" (#86) * Use grpc-go for interop tests (#88) * fix grpc docker build script (#90) * Upgrade bazel to 0.4.4 (#92) * Upgrade bazel to 0.4.4 * Update istio/proxy for GRPC v1.1.1 (#89) * Fix proxy_flow to align grpc 1.1.1 * Fix ProxyFlow leak (#93) * Basic GRPC request compression support (#94) * Remove undefined flag of Go stress client (#95) * t-test changes to check that x-endpoint-api-userinfo is received by grpc (#96) service. * Fix typo (#97) Change-Id: Idff7a0f23d013f1d67e6cb3c890c54fc0b21ef2e * not to use api_key if service is not activated. (#98) * Escape run description Change-Id: I6a66f9be92314218ee6a19b2d82897b6c55c42d2 * Fix grpc interop stress test script. (#103) * try to escape json again. (#106) * Add t test for fail wrong api key. (#104) Change-Id: I0ea9ed4ba94f13283616eae00b93f067f9c00cf5 * Allow grpc interop stress test fail once. (#105) Change-Id: I5a090eae45c1d9b7d0641b2f09757bb373746aa1 * Update to latest endpoints-tool. (#110) * Deprecate x-security (#101) * Deprecate x-security * Add one more swagger file * Update swagger.yaml file also. * Fix api_key * Fix indentation * Update api keys correctly * Fix indentation * Update CHANGELOG (#112) * Update version number to 1.2.0. (#111) * Quick fix of bookstore-server race (#115) * Support apikey based traffic restriction (#120) * fix gcloud command (#121) * add -- for gcloud compute ssh (#122) * Dev (#123) * update gcloud command * update gcloud command * update gcloud ssh command (#124) * update gcloud ssh command * trigger presubmit test * trigger jenkins test * Made test cases waiting for the report respose (#125) * add a version flag to support rollback (#126) * Updated the commit id of endpoints tools repo (#128) * Set gRPC max send/receive message size to unlimited (#132) * Set max send/receive message size to unlimited * fix format * Comply with istio/proxy#225 (#134) * Comply with istio/proxy#225 * fix_format * fix go build * Merge rate_limit branch to master (#137) * Added AllocateQuotaRequest/Response support (#99) * Added AllocateQuotaRequest/Response support * Added AllocateQuotaRequest/Response support * Added test cases for rate limiting * Fixed failed test cases caused by recent changes * Removed unnecessary variable and applied server config to disable report cache * Removed unnecessary variable and applied server config to disable report cache * Updated commit id of istio/proxy repo * Set max column to 80, Added report request handler * Merge latest changes from master (#107) * not to use api_key if service is not activated. (#98) * Escape run description Change-Id: I6a66f9be92314218ee6a19b2d82897b6c55c42d2 * Fix grpc interop stress test script. (#103) * try to escape json again. (#106) * Add t test for fail wrong api key. (#104) Change-Id: I0ea9ed4ba94f13283616eae00b93f067f9c00cf5 * Allow grpc interop stress test fail once. (#105) Change-Id: I5a090eae45c1d9b7d0641b2f09757bb373746aa1 * Updated the latest commit from istio/proxy (#109) * Updated commit id of istio/proxy (#117) * Updated commit id of istio/proxy * Fixed proto_pass_perf tool compilation error * Fixed proto_pass_perf tool compilation error * Recover codes acdientally removed * Fixed code style * Update istio/proxy commitid (#131) * Update commitid of istio/proxy
sarvaniv
added a commit
that referenced
this pull request
Apr 24, 2017
* Firebase: Merge changes with master. (#77) * Fixed bazel install Change-Id: Ic573e8e4cc2900fa44dfa5c67d6728c58283b649 * Make docker slaves consistent with jenkinsci/slave Change-Id: I6251e93ca7f9e588a552fbf5562d0ec24534480a * Align with latest istio/proxy. (#73) * Support HEAD request in transcoding (#74) * Support HEAD request in transcoding * Removed unused variables * Fixing bazel install for ubuntu salve Change-Id: I184624d166dd49ccd4242f3bcfc54b1182216909 * Merge from master to firebase (#84) * Fixed bazel install Change-Id: Ic573e8e4cc2900fa44dfa5c67d6728c58283b649 * Make docker slaves consistent with jenkinsci/slave Change-Id: I6251e93ca7f9e588a552fbf5562d0ec24534480a * Align with latest istio/proxy. (#73) * Support HEAD request in transcoding (#74) * Support HEAD request in transcoding * Removed unused variables * Fixing bazel install for ubuntu salve Change-Id: I184624d166dd49ccd4242f3bcfc54b1182216909 * Use open-sourced scripts (#76) * Use open-sourced scripts * Add a workaround PEX issue * Update to istio/proxy with mixer_client integration. (#78) * Align with istio/proxy. (#79) * Align with istio/proxy. Change-Id: Ic175022bffc559bbc07bea823fde38a5bebc654c * Update go file. Change-Id: If0fd2a52b5b43fecc6b5ec4a1ad2864877de5b17 * Fix debian jessie package issue * Change commit ID to consume new security rules in proxy * Fixes typo in script * Merge from master to firebase branch (#114) * Fixed bazel install Change-Id: Ic573e8e4cc2900fa44dfa5c67d6728c58283b649 * Make docker slaves consistent with jenkinsci/slave Change-Id: I6251e93ca7f9e588a552fbf5562d0ec24534480a * Align with latest istio/proxy. (#73) * Support HEAD request in transcoding (#74) * Support HEAD request in transcoding * Removed unused variables * Fixing bazel install for ubuntu salve Change-Id: I184624d166dd49ccd4242f3bcfc54b1182216909 * Use open-sourced scripts (#76) * Use open-sourced scripts * Add a workaround PEX issue * Update to istio/proxy with mixer_client integration. (#78) * Align with istio/proxy. (#79) * Align with istio/proxy. Change-Id: Ic175022bffc559bbc07bea823fde38a5bebc654c * Update go file. Change-Id: If0fd2a52b5b43fecc6b5ec4a1ad2864877de5b17 * Fix debian jessie package issue * Fixes typo in script * Modify test justification. (#83) * Update NGINX to 1.11.9 (#75) * Update NGINX to 1.11.9 * Remove mixer_client repo. (#85) * Revert "Update NGINX to 1.11.9" (#86) * Use grpc-go for interop tests (#88) * fix grpc docker build script (#90) * Upgrade bazel to 0.4.4 (#92) * Upgrade bazel to 0.4.4 * Update istio/proxy for GRPC v1.1.1 (#89) * Fix proxy_flow to align grpc 1.1.1 * Fix ProxyFlow leak (#93) * Basic GRPC request compression support (#94) * Remove undefined flag of Go stress client (#95) * t-test changes to check that x-endpoint-api-userinfo is received by grpc (#96) service. * Fix typo (#97) Change-Id: Idff7a0f23d013f1d67e6cb3c890c54fc0b21ef2e * not to use api_key if service is not activated. (#98) * Escape run description Change-Id: I6a66f9be92314218ee6a19b2d82897b6c55c42d2 * Fix grpc interop stress test script. (#103) * try to escape json again. (#106) * Add t test for fail wrong api key. (#104) Change-Id: I0ea9ed4ba94f13283616eae00b93f067f9c00cf5 * Allow grpc interop stress test fail once. (#105) Change-Id: I5a090eae45c1d9b7d0641b2f09757bb373746aa1 * Update to latest endpoints-tool. (#110) * Deprecate x-security (#101) * Deprecate x-security * Add one more swagger file * Update swagger.yaml file also. * Fix api_key * Fix indentation * Update api keys correctly * Fix indentation * Update CHANGELOG (#112) * Update version number to 1.2.0. (#111) * Merge from master into Firebase (#119) * Fixed bazel install Change-Id: Ic573e8e4cc2900fa44dfa5c67d6728c58283b649 * Make docker slaves consistent with jenkinsci/slave Change-Id: I6251e93ca7f9e588a552fbf5562d0ec24534480a * Align with latest istio/proxy. (#73) * Support HEAD request in transcoding (#74) * Support HEAD request in transcoding * Removed unused variables * Fixing bazel install for ubuntu salve Change-Id: I184624d166dd49ccd4242f3bcfc54b1182216909 * Use open-sourced scripts (#76) * Use open-sourced scripts * Add a workaround PEX issue * Update to istio/proxy with mixer_client integration. (#78) * Align with istio/proxy. (#79) * Align with istio/proxy. Change-Id: Ic175022bffc559bbc07bea823fde38a5bebc654c * Update go file. Change-Id: If0fd2a52b5b43fecc6b5ec4a1ad2864877de5b17 * Fix debian jessie package issue * Fixes typo in script * Modify test justification. (#83) * Update NGINX to 1.11.9 (#75) * Update NGINX to 1.11.9 * Remove mixer_client repo. (#85) * Revert "Update NGINX to 1.11.9" (#86) * Use grpc-go for interop tests (#88) * fix grpc docker build script (#90) * Upgrade bazel to 0.4.4 (#92) * Upgrade bazel to 0.4.4 * Update istio/proxy for GRPC v1.1.1 (#89) * Fix proxy_flow to align grpc 1.1.1 * Fix ProxyFlow leak (#93) * Basic GRPC request compression support (#94) * Remove undefined flag of Go stress client (#95) * t-test changes to check that x-endpoint-api-userinfo is received by grpc (#96) service. * Fix typo (#97) Change-Id: Idff7a0f23d013f1d67e6cb3c890c54fc0b21ef2e * not to use api_key if service is not activated. (#98) * Escape run description Change-Id: I6a66f9be92314218ee6a19b2d82897b6c55c42d2 * Fix grpc interop stress test script. (#103) * try to escape json again. (#106) * Add t test for fail wrong api key. (#104) Change-Id: I0ea9ed4ba94f13283616eae00b93f067f9c00cf5 * Allow grpc interop stress test fail once. (#105) Change-Id: I5a090eae45c1d9b7d0641b2f09757bb373746aa1 * Update to latest endpoints-tool. (#110) * Deprecate x-security (#101) * Deprecate x-security * Add one more swagger file * Update swagger.yaml file also. * Fix api_key * Fix indentation * Update api keys correctly * Fix indentation * Update CHANGELOG (#112) * Update version number to 1.2.0. (#111) * Quick fix of bookstore-server race (#115) * Firebase merge from master (#138) * Fixed bazel install Change-Id: Ic573e8e4cc2900fa44dfa5c67d6728c58283b649 * Make docker slaves consistent with jenkinsci/slave Change-Id: I6251e93ca7f9e588a552fbf5562d0ec24534480a * Align with latest istio/proxy. (#73) * Support HEAD request in transcoding (#74) * Support HEAD request in transcoding * Removed unused variables * Fixing bazel install for ubuntu salve Change-Id: I184624d166dd49ccd4242f3bcfc54b1182216909 * Use open-sourced scripts (#76) * Use open-sourced scripts * Add a workaround PEX issue * Update to istio/proxy with mixer_client integration. (#78) * Align with istio/proxy. (#79) * Align with istio/proxy. Change-Id: Ic175022bffc559bbc07bea823fde38a5bebc654c * Update go file. Change-Id: If0fd2a52b5b43fecc6b5ec4a1ad2864877de5b17 * Fix debian jessie package issue * Fixes typo in script * Modify test justification. (#83) * Update NGINX to 1.11.9 (#75) * Update NGINX to 1.11.9 * Remove mixer_client repo. (#85) * Revert "Update NGINX to 1.11.9" (#86) * Use grpc-go for interop tests (#88) * fix grpc docker build script (#90) * Upgrade bazel to 0.4.4 (#92) * Upgrade bazel to 0.4.4 * Update istio/proxy for GRPC v1.1.1 (#89) * Fix proxy_flow to align grpc 1.1.1 * Fix ProxyFlow leak (#93) * Basic GRPC request compression support (#94) * Remove undefined flag of Go stress client (#95) * t-test changes to check that x-endpoint-api-userinfo is received by grpc (#96) service. * Fix typo (#97) Change-Id: Idff7a0f23d013f1d67e6cb3c890c54fc0b21ef2e * not to use api_key if service is not activated. (#98) * Escape run description Change-Id: I6a66f9be92314218ee6a19b2d82897b6c55c42d2 * Fix grpc interop stress test script. (#103) * try to escape json again. (#106) * Add t test for fail wrong api key. (#104) Change-Id: I0ea9ed4ba94f13283616eae00b93f067f9c00cf5 * Allow grpc interop stress test fail once. (#105) Change-Id: I5a090eae45c1d9b7d0641b2f09757bb373746aa1 * Update to latest endpoints-tool. (#110) * Deprecate x-security (#101) * Deprecate x-security * Add one more swagger file * Update swagger.yaml file also. * Fix api_key * Fix indentation * Update api keys correctly * Fix indentation * Update CHANGELOG (#112) * Update version number to 1.2.0. (#111) * Quick fix of bookstore-server race (#115) * Support apikey based traffic restriction (#120) * fix gcloud command (#121) * add -- for gcloud compute ssh (#122) * Dev (#123) * update gcloud command * update gcloud command * update gcloud ssh command (#124) * update gcloud ssh command * trigger presubmit test * trigger jenkins test * Made test cases waiting for the report respose (#125) * add a version flag to support rollback (#126) * Updated the commit id of endpoints tools repo (#128) * Set gRPC max send/receive message size to unlimited (#132) * Set max send/receive message size to unlimited * fix format * Comply with istio/proxy#225 (#134) * Comply with istio/proxy#225 * fix_format * fix go build * Merge rate_limit branch to master (#137) * Added AllocateQuotaRequest/Response support (#99) * Added AllocateQuotaRequest/Response support * Added AllocateQuotaRequest/Response support * Added test cases for rate limiting * Fixed failed test cases caused by recent changes * Removed unnecessary variable and applied server config to disable report cache * Removed unnecessary variable and applied server config to disable report cache * Updated commit id of istio/proxy repo * Set max column to 80, Added report request handler * Merge latest changes from master (#107) * not to use api_key if service is not activated. (#98) * Escape run description Change-Id: I6a66f9be92314218ee6a19b2d82897b6c55c42d2 * Fix grpc interop stress test script. (#103) * try to escape json again. (#106) * Add t test for fail wrong api key. (#104) Change-Id: I0ea9ed4ba94f13283616eae00b93f067f9c00cf5 * Allow grpc interop stress test fail once. (#105) Change-Id: I5a090eae45c1d9b7d0641b2f09757bb373746aa1 * Updated the latest commit from istio/proxy (#109) * Updated commit id of istio/proxy (#117) * Updated commit id of istio/proxy * Fixed proto_pass_perf tool compilation error * Fixed proto_pass_perf tool compilation error * Recover codes acdientally removed * Fixed code style * Update istio/proxy commitid (#131) * Update commitid of istio/proxy * Update Proxy commit id to latest (#143)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested that service deployment of the files is successful via gcloud.