-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document (or remove) pkg-info dependency #517
Comments
Is it sound to add pkg-info to clj-refactor.el/clj-refactor.el Line 13 in f368c56
cc/ @bbatsov |
Taking a look, pkg-info looks like a vanilla package that would be safe to depend on, like any other package. |
|
SGTM, thanks for the insight! Is the version logic working nicely in cider? I do remember some headscratching issues that had the build failing for a while. If it happened to be still hacky, perhaps we could try to solve the problem again from scratch, assuming we came up with something radically simpler. |
Yeah, all the problems with CIDER's solution have been addressed. You also have to keep in mind that |
Thanks! Hope I can get this quickly fixed then. |
Expected behavior
Cider connects as usual.
Actual behavior
This error goes away if
pkg-info
is installed.Steps to reproduce the problem
With a fresh Emacs install,
use-package
the following:clojure-mode
cider
clj-refactor
Add a hook to start
clj-refactor-mode
with automatically withclojure-mode
.M-x cider-connect
Environment & Version information
clj-refactor.el version information
clj-refactor 3.5.2 (package: 20220315.2251), refactor-nrepl 3.1.0
CIDER version information
Leiningen or Boot version
Leiningen 2.9.8 on Java 17.0.2 OpenJDK 64-Bit Server VM
Emacs version
GNU Emacs 28.1 (build 2, x86_64-pc-linux-gnu, GTK+ Version 3.24.20, cairo version 1.16.0)
of 2022-05-09
Operating system
Ubuntu 18.04.6 LTS
The text was updated successfully, but these errors were encountered: