Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix native stack trace test and remove TIMERWRAP assertion in Node 11 #282

Merged
merged 2 commits into from
Dec 4, 2018
Merged

Fix native stack trace test and remove TIMERWRAP assertion in Node 11 #282

merged 2 commits into from
Dec 4, 2018

Commits on Dec 4, 2018

  1. Fix native stack trace test 

    In v8 7.0, Array.sort() was moved from a JS-based implementation to
Torque:
v8/v8@fa11e2a

This means Array.sort() isn't in v8's `array.js` file anymore.
Apparently the goal is to eventually move all or most JS implementations
of builtins like Array to to Torque, so 'native' is a shrinking
category. We may need to do something to detect those Torque things?
    @goto-bus-stop
    goto-bus-stop committed Dec 4, 2018
    Configuration menu
    Copy the full SHA
    b589f03 View commit details
    Browse the repository at this point in the history

  2. Account for TIMERWRAP removal in Node 11.

    @goto-bus-stop
    goto-bus-stop committed Dec 4, 2018
    Configuration menu
    Copy the full SHA
    ff43b2d View commit details
    Browse the repository at this point in the history