Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build failure due to C++17 use / lack of explicit standard setting #516

Closed
CasualPokePlayer opened this issue Dec 27, 2022 · 1 comment
Closed

Build failure due to C++17 use / lack of explicit standard setting #516

CasualPokePlayer opened this issue Dec 27, 2022 · 1 comment

Comments

@CasualPokePlayer
Copy link
Contributor

CasualPokePlayer commented Dec 27, 2022 •
edited
Loading

OS: Debian 11
Compiler: gcc/g++ (Debian 10.2.1-6) 10.2.1 20210110

std::optional is used in a few places, which is a C++17 feature. This results in a build failure for me with the build.sh, as the gcc shipped by Debian defaults to C++14.

Issue is likely resolvable by simply explicitly having an -std=c++17 flag? Maybe also useful: https://www.gnu.org/software/autoconf-archive/ax_cxx_compile_stdcxx_17.html
@CasualPokePlayer CasualPokePlayer changed the title Build failure due to C++17 use Build failure due to C++17 use / lack of explicit standard setting Dec 27, 2022
@clementgallet
Copy link
Owner

Thanks, the code is written to support c++11, but apparently when I switched to autoconf, I didn't add the flag during compilation.

clementgallet added a commit that referenced this issue Dec 28, 2022
@clementgallet
Remove code needing c++17, and add the c++11 compile flag (#516)
fba5344
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@clementgallet @CasualPokePlayer