Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Header IDs interfere with jingo #234

Closed
mjflan opened this issue Nov 14, 2017 · 1 comment
Closed

Header IDs interfere with jingo #234

mjflan opened this issue Nov 14, 2017 · 1 comment
Labels

Comments

@mjflan
Copy link

mjflan commented Nov 14, 2017

If I add a document header:

### login

...to my document then the toolbar goes away. At that point, I have to edit the file externally to fix it by changing the header name.

I think this is an exception in the Jingo javascript in the browser, but a brief review shows that there are element IDs that are easily duplicated by users that interfere with jingo's functionality. I would suggest replacing built-in element IDs with stylized names like _jingo_login or something of that sort. It would make it much more difficult for regular users (like me) to bump into them and break the wiki.

@claudioc
Copy link
Owner

Ouch, you're right.

Let me fix this :)

@claudioc claudioc added the bug label Feb 25, 2018
claudioc added a commit that referenced this issue Feb 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants