Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OTA changes from move to LLDS in linguistics #311

Merged
merged 1 commit into from
May 1, 2024

Conversation

jpnp
Copy link
Contributor

@jpnp jpnp commented May 1, 2024

No description provided.

@andmor-
Copy link
Member

andmor- commented May 1, 2024

Please update file name according to the instructions in this repository front page for new SPs (also applies to new entityIDs):
2. ... new file following the same naming convention: [New SP File Name] = [SP entityID].replace("http(s)?://", "").replace("/", "%2F") + ".xml"

@jpnp
Copy link
Contributor Author

jpnp commented May 1, 2024

entityID="https://llds.ling-phil.ox.ac.uk/shibboleth"

File is named "llds.ling-phil.ox.ac.uk%2Fshibboleth.xml"

I think that's right?

Thanks,
John

@andmor- andmor- merged commit 8770782 into clarin-eric:master May 1, 2024
1 check passed
@andmor-
Copy link
Member

andmor- commented May 1, 2024

Yes. My bad. Merged, lets see what the QA bot says... it should comment on this issue in about 10mins after merge

@clarin-bot
Copy link
Collaborator

Automated QA assessment complete.

Please check your SP in the master QA report (or in its standalone QA report) and fix all entries marked in red. Any entries marked in yellow should also be fixed, though for those we apply some tolerance on a case by case basis.

The following SPs changed their QA assessment with this pull request:

Your SP has successfully passed our automated QA assessment when the master QA report does not include any entries for it.

To submit your SAML fixes, either commit them to this pull request or open a new one.

@andmor-
Copy link
Member

andmor- commented May 1, 2024

All good. You can ignore the warning about "description" length.

Released with r00092

Since this is a new entityID might take some 24h to propagate.

You can follow the propagation status across federation here: https://centres.clarin.eu/spf

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants