Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement crate_description!, crate_name! and app_from_crate! macros #798

Merged
merged 1 commit into from
Dec 31, 2016
Merged

Implement crate_description!, crate_name! and app_from_crate! macros #798

merged 1 commit into from
Dec 31, 2016

Conversation

nabijaczleweli
Copy link
Contributor

@nabijaczleweli nabijaczleweli commented Dec 31, 2016

Includes documentation.

@coveralls
Copy link

coveralls commented Dec 31, 2016

Coverage Status

Coverage decreased (-0.2%) to 91.43% when pulling 4d9a82d on nabijaczleweli:feat/778-simple-cargo-app into 805b9b6 on kbknapp:master.

@coveralls
Copy link

coveralls commented Dec 31, 2016

Coverage Status

Coverage decreased (-0.2%) to 91.43% when pulling 4d9a82d on nabijaczleweli:feat/778-simple-cargo-app into 805b9b6 on kbknapp:master.

@kbknapp
Copy link
Member

kbknapp commented Dec 31, 2016

Awesome, thanks for knocking this out! @homu r+

@homu
Copy link
Contributor

homu commented Dec 31, 2016

📌 Commit 4d9a82d has been approved by kbknapp

homu added a commit that referenced this pull request Dec 31, 2016
Implement crate_description!, crate_name! and app_from_crate! macros

Includes documentation.
@homu
Copy link
Contributor

homu commented Dec 31, 2016

⚡ Test exempted - status

@homu homu merged commit 4d9a82d into clap-rs:master Dec 31, 2016
@Arnavion
Copy link
Contributor

So

let app = clap_app! { name =>
    (author: crate_authors!())
    (version: crate_version!())
    ...
};

becomes

let app = clap_app! {
    @app (app_from_crate!())
    ...
};

right? Might be nice to document it since the only way I found out I had to put @app and the parentheses around app_from_crate!() was by reading the source for how clap_app! expands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants