Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle replacing colons with custom separators in crate_authors!() #780

Merged
merged 5 commits into from
Dec 19, 2016
Merged

Handle replacing colons with custom separators in crate_authors!() #780

merged 5 commits into from
Dec 19, 2016

Conversation

nabijaczleweli
Copy link
Contributor

Discussion: #779
r? @kbknapp

@nabijaczleweli
Replace colons with newlines in crate_authors!()
1a84ce2 
The implementation is basically manually expanded lazy_static! macro
(with some hand-crafted simplifications and inlining), since you can't
use extern crates (and therefore import macros therefrom) in macros.

This ensures that you get this:

    p:\Rust\http>target\debug\http -h
    http 0.1.0
    thecoshman <thecoshman@gmail.com>
    nabijaczleweli <nabijaczleweli@gmail.com>
    Host These Things Please - a basic HTTP server for hosting a folder fast and simply

Instead of this:

    p:\Rust\http>target\debug\http -h
    http 0.1.0
    thecoshman <thecoshman@gmail.com>:nabijaczleweli <nabijaczleweli@gmail.com>
    Host These Things Please - a basic HTTP server for hosting a folder fast and simply

Closes #779
@nabijaczleweli
Inline lazy_static! even harder in crate_authors!()
05f4953 
Functionality remains the same
@nabijaczleweli
Default crate_authors!() macro to colon version. Add arm to handle cu…
15d1619 
…stom separators

This makes default crate_authors!() invocation same as before the
changes
@kbknapp
Copy link
Member

kbknapp commented Dec 18, 2016

Could you a quick doc blurb about the new method as well? It should be good for a merge after that. 👍

@nabijaczleweli
Copy link
Contributor Author

Done

@coveralls
Copy link

coveralls commented Dec 18, 2016 •
edited
Loading

Coverage Status

Coverage increased (+0.05%) to 91.162% when pulling 15d1619 on nabijaczleweli:fix/779/crate_authors!-newlines into 274afb1 on kbknapp:master.

@coveralls
Copy link

coveralls commented Dec 18, 2016 •
edited
Loading

Coverage Status

Coverage decreased (-0.02%) to 91.111% when pulling 83bacb8 on nabijaczleweli:fix/779/crate_authors!-newlines into dd31341 on kbknapp:master.

@coveralls
Copy link

coveralls commented Dec 18, 2016 •
edited
Loading

Coverage Status

Coverage decreased (-0.02%) to 91.111% when pulling 83bacb8 on nabijaczleweli:fix/779/crate_authors!-newlines into dd31341 on kbknapp:master.

@kbknapp
Copy link
Member

kbknapp commented Dec 18, 2016

@homu r+

@homu
Copy link
Contributor

homu commented Dec 18, 2016

📌 Commit 83bacb8 has been approved by kbknapp

homu added a commit that referenced this pull request Dec 18, 2016
@homu
Auto merge of #780 - nabijaczleweli:fix/779/crate_authors!-newlines, …
21b1414 
…r=kbknapp

Handle replacing colons with custom separators in crate_authors!()

Discussion: #779
r? @kbknapp
@homu
Copy link
Contributor

homu commented Dec 18, 2016

⌛ Testing commit 83bacb8 with merge d5361c4...

homu added a commit that referenced this pull request Dec 18, 2016
@homu
Auto merge of #780 - nabijaczleweli:fix/779/crate_authors!-newlines, …
d5361c4 
…r=kbknapp

Handle replacing colons with custom separators in crate_authors!()

Discussion: #779
r? @kbknapp
@homu
Copy link
Contributor

homu commented Dec 19, 2016

☀️ Test successful - status

@homu homu merged commit 83bacb8 into clap-rs:master Dec 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nabijaczleweli @kbknapp @coveralls @homu