Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(Errors): refactors how errors are created for deduplication #312

Merged
merged 1 commit into from
Oct 6, 2015

Conversation

kbknapp
Copy link
Member

@kbknapp kbknapp commented Oct 6, 2015

This should finally fix all the cases for @elszben since there's now only a single way to determine what goes in the usage string...not 20 😄

Closes #277

@yo-bot
Copy link

yo-bot commented Oct 6, 2015

r? @sru

(yo-bot has picked a reviewer for you, use r? to override)

@sru
Copy link
Contributor

sru commented Oct 6, 2015

@homu r+

@homu
Copy link
Contributor

homu commented Oct 6, 2015

📌 Commit a88827b has been approved by sru

homu added a commit that referenced this pull request Oct 6, 2015
refactor(Errors): refactors how errors are created for deduplication

This should **finally** fix all the cases for @elszben since there's now only a single way to determine what goes in the usage string...not 20 😄

Closes #277
@homu
Copy link
Contributor

homu commented Oct 6, 2015

⌛ Testing commit a88827b with merge 1afd566...

@homu
Copy link
Contributor

homu commented Oct 6, 2015

☀️ Test successful - status

@homu
Copy link
Contributor

homu commented Oct 6, 2015

👀 Test was successful, but fast-forwarding failed: 422 Reference update failed

@sru
Copy link
Contributor

sru commented Oct 6, 2015

@kbknapp rebase?

@kbknapp
Copy link
Member Author

kbknapp commented Oct 6, 2015

@sru yeah just needs a rebase onto master since #311 merged. You can do it if you like, or I'll do it on the morning ;)

@sru
Copy link
Contributor

sru commented Oct 6, 2015

@homu r+

@homu
Copy link
Contributor

homu commented Oct 6, 2015

📌 Commit 6b90f1a has been approved by sru

homu added a commit that referenced this pull request Oct 6, 2015
refactor(Errors): refactors how errors are created for deduplication

This should **finally** fix all the cases for @elszben since there's now only a single way to determine what goes in the usage string...not 20 😄

Closes #277
@homu
Copy link
Contributor

homu commented Oct 6, 2015

⌛ Testing commit 6b90f1a with merge 2cc65cd...

@homu
Copy link
Contributor

homu commented Oct 6, 2015

☀️ Test successful - status

@homu homu merged commit 6b90f1a into master Oct 6, 2015
@kbknapp kbknapp deleted the issue-277-refactor branch October 6, 2015 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unexpected elements in usage
4 participants