Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set TakesValue to true for positional args when building #2682

Merged
merged 1 commit into from
Aug 12, 2021
Merged

Set TakesValue to true for positional args when building #2682

merged 1 commit into from
Aug 12, 2021

Conversation

pksunkara
Copy link
Member

Fixes #2680 since that can now be done in #2677

@pksunkara pksunkara requested a review from a team August 12, 2021 20:30
epage
epage approved these changes Aug 12, 2021
View reviewed changes
Copy link
Member

@epage epage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really good cleanup, centralizing knowledge of what is a positional argument and making the intent clear. This helps a lot

@pksunkara pksunkara merged commit 476dd19 into master Aug 12, 2021
@pksunkara pksunkara deleted the checker branch August 12, 2021 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@epage epage epage approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Need a debug assert for AllowInvalidUtf8 requiring TakesValue
2 participants
@pksunkara @epage