-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix benchmarks #1698
Fix benchmarks #1698
Conversation
Are you working on making them use criterion? |
Nope, not yet. I'll get to it the day after tomorrow. |
I can work on this if you are busy. |
I was, but I'm getting to it in several hours. |
e64635f
to
b5994d1
Compare
Rebased on top of #1700 , will need to merge that first. All of the benches are moved to criterion, but, quite frankly, most of them are useless. I'm plaiyng with them to figure out which. |
b5994d1
to
ef280c8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one minor comment, and please rebase on master
ef280c8
to
57ca488
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bors r+
Build succeeded
|
No description provided.