im(arg_enum): allows ascii case insensitivity for enum variants #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows creating an enum with CamelCase to follow Rust guidelines, but then will match ascii case insensitive. This means variant SomeEnum::Emacs would match string "emacs". Closes #104
kbknapp
added a commit
that referenced
this pull request
May 5, 2015
im(arg_enum): allows ascii case insensitivity for enum variants
|
I recommend adding a test for this feature - for some reason it didn't work for me and lower-case versions were not recognized. I have seen the code and would believe it should work too, but ... a test will just make sure of it and is easy to implement too. |
|
Just found the issue - it's due to four different rules based off the enum type (pub/priv, derives/not). I'm putting in a fix right now. You're right though, I need to write a test for this. |
|
Once #106 is merged, this should work. It doesn't include a test though, I'll have to write that tonight, then I'll bump the crates.io version. |
|
Everything should be good now. |
|
Thank you, it does indeed ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows creating an enum with CamelCase to follow Rust guidelines, but
then will match ascii case insensitive. This means variant
SomeEnum::Emacs would match string "emacs".
Closes #104